1654511 - [wpt-sync] Sync PR 24606 - [Sheriff] Revert "Deflake preservesPitch tests"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24606 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24606
Details from upstream follow.

Roger McFarlane <[e-mail]> wrote:

[Sheriff] Revert "Deflake preservesPitch tests"

This reverts commit 7b6c4007896853f91f32bd69b2c770f0210c66e5.

Reason for revert:

Post this change, preservesPitch seems to consistently fail.

https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests

Original change's description:

Deflake preservesPitch tests

This CL changes preservesPitch tests to wait until the audioElement's
currentTime is at least 0.5 seconds before trying to detect the pitch.
Without this check, the test can try to detect the pitch before the
audio has played enough, which can return a dominant frequency of 0Hz
and fail the test.

The CL also makes a few stylistic changes, and fixes an off-by-one error
in the number of increments used to calculate frequencies.

Bug: 1096238
Change-Id: I6e98e172862a47bea1c4026737138293914f7906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298281
Auto-Submit: Thomas Guilbert \<[e-mail]>
Commit-Queue: Philip Jägenstedt \<[e-mail]>
Reviewed-by: Philip Jägenstedt \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#788535}

TBR=[e-mail],[e-mail]

Change-Id: I0042f73ca9c5de7d82be1200794c45b46a003f9b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1096238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299183
Reviewed-by: Roger McFarlane \<[e-mail]>
Commit-Queue: Roger McFarlane \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#788626}

---

Edited by @foolip to also include the reland with fixes:

Reland preservesPitch test deflake, fix timeouts

This CL relands "Deflake preservesPitch tests", which was reverted by:
commit f19f3404371bba3cac38bf1bcf672ef5f3e96558.

It also attempts to incorporate some of the WPT changes made upstream,
but not yet landed, in:
https://github.com/web-platform-tests/wpt/pull/24599

Specifically, it fixes typos in the Safari prefixes, and explicitly
starts the audio context. However, it is different from the PR, since
it reuses the same Audio element, MediaElementAudioSourceNode and
AudioContext. This is an attempt to cut down on overhead costs and
fix test timeouts. We instead reset the audio.currentTime to 0, and
only create a new analyser node for each test.

Bug: 1105877, 1096238
Change-Id: Ie528ec0b7c38d9df59fcb04696c810e6d1c232f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300929
Commit-Queue: Thomas Guilbert <[e-mail]>
Auto-Submit: Thomas Guilbert <[e-mail]>
Reviewed-by: Philip Jägenstedt <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#789262}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 24606 applied with additional changes from upstream: f96e3094d5ad65792ef0cfe4fae3202c7ad99741, 09fbe278df64f25b6d0fea96ba6a5655ae19f2a6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffaa423f09599f6f1fd25aa425c26a92e90c786a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
PASS : 6
FAIL : 3

Chrome

OK : 1
PASS : 9

Safari

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/embedded-content/media-elements/preserves-pitch.html
Slow-downs should change the pitch when preservesPitch=false: FAIL (Chrome: PASS)
Speed-ups should change the pitch when preservesPitch=false: FAIL (Chrome: PASS)
Test that preservesPitch is present and unprefixed.: FAIL (Chrome: PASS)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bd1b8b0883b
[wpt PR 24606] - [Sheriff] Revert "Deflake preservesPitch tests", a=testonly

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2bd1b8b0883b