1654518 - New wpt failures in /html/semantics/embedded-content/media-elements/preserves-pitch.html

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 24606 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/html/semantics/embedded-content/media-elements/preserves-pitch.html
Slow-downs should change the pitch when preservesPitch=false: FAIL (Chrome: PASS)
Speed-ups should change the pitch when preservesPitch=false: FAIL (Chrome: PASS)
Test that preservesPitch is present and unprefixed.: FAIL (Chrome: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1654511 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Looks like the test isn't happy with our pitch preservation. Paul, is this something you know about? Would you expect us to pass?

Comment 2

[C.M.Chang[:chunmin]]

It seems DecodedStream.mPreservesPitch has no effect?

Comment 3

[Paul Adenot (:padenot)]

What chunmin says is the correct answer. playbackRate and preservesPitch have no effect when playing through the Web Audio API or using a MediaStream.

This is tracked as https://bugzilla.mozilla.org/show_bug.cgi?id=1517199 and alastor wanted to take a shot at it, but the sooner the better, we've waited long enough.

Comment 4

[Alastor Wu [:alwu]]

Hi, Paul,
I wonder if there is any historical reason for which we use mozPreservesPitch, and should we remove it and use preservesPitch instead?
Thank you.

Comment 5

[Paul Adenot (:padenot)]

We implemented it before it was standardized, that's all.

Comment 6

[Mathew Hodson]

I think this bug can be closed since bug 1652950 landed.