1654604 - Hold CSV Import to Nightly for Fx80

Status: VERIFIED FIXED

(Toolkit :: Password Manager, task, P1)

Description

[Matthew N. [:MattN]]

The feature isn't ready for release in Fx80 so limit it to Nightly-only until it is.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1654604 - Hold CSV Import to Nightly for Fx80. r=severin

Depends on D84618

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1273eeabfc21
Hold CSV Import to Nightly for Fx80. r=severin,fluent-reviewers,flod

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1273eeabfc21

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 80.0a1 build (Build ID: 20200724093206) on Windows 10 x64, Mac 10.14.6 and Ubuntu 18.06 x64. Here are the scenarios that I have verified:

• Verified that the boolean "signon.management.page.fileImport.enabled" pref is present and is set to true by default on Nightly.
• Verified that the "Import from a File..." option from the meatball menu is hidden when the pref is set to false.
• Verified that the "from a file" link from the no logins screen (when there are zero logins) is hidden when the pref is set to false.
• Verified that there are no UI issues on the meatball menu and on the logins screen when the pref is set to false.

I will need info myself to also verify this issue when the Firefox Beta 80 will be available to check that the pref will be set to false by default. Also, I will not change the status and the flags for this issue until then.

Comment 5

[Julien Cristau [:jcristau]]

Thanks Matt and Cosmin.

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Firefox 80.0b1 is available and in order to verify this I have updated the Beta 79.0b9 version to Beta 80.0b1 and verified the following scenarios:

• Verified that the "signon.management.page.fileImport.enabled" pref is present in Beta 80.
• Verified that the pref is set to false by default on Beta build.
• Verified that the "Import from a File..." option from the meatball menu is hidden while the pref is set to false.
• Verified that the "from a file" link from the no logins screen (when there are zero logins) is hidden while the pref is set to false.
• Verified that there are no UI issues on the meatball menu and on the logins screen when the pref is set to false.
• Verified that the "Import from a File..." option from the meatball menu is displayed after changing the pref to true.
• Verified that the "from a file" link from the no logins screen is displayed after changing the pref to true.

I have verified this on Windows 10 x64, Mac 10.14 and Ubuntu 20.04 x64.