1654657 - Refine the logic of choosing main controller

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

In 1642715, we add a support to know if a controller is being used in fullscreen, the controller is being used in fullscreeen should be equal to the one being used in PIP mode, which might be important to user.

Therefore, we should make it steal the controllability from current main controller.

---

In addition, GeckoView also wants having an ablility to set the main controller directly.

Comment 1

[Alastor Wu [:alwu]]

However, there are some situations [1] which is still unclear to me, and we might not want to make controller become the main controller under those situations. eg. media failed to load, but enters fullscreen

[1] https://phabricator.services.mozilla.com/D84189#inline-482753

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1654657 - part1 : update fullscreen change in media element.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1654657 - part2 : treat media controller being used in fullscreen as same as the one being used in PIP mode.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1654657 - part3 : remove unused function 'IsInPictureInPictureMode()'.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1654657 - part4 : test 'NotifyMediaFullScreenState()' in gTest.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1654657 - part5 : request to become a main controller when controller enters fullscreen.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1654657 - part6 : refine the logic of requesting main controller.

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1654657 - part7 : add test cases for choosing main controller.

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1654657 - part8 : add test cases to ensure non-eligible media can be controlled when it enters fullscreen or PIP mode.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bcee92cca2f
part1 : update fullscreen change in media element. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a38035f87274
part2 : treat media controller being used in fullscreen as same as the one being used in PIP mode. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/d250ac96b75f
part3 : remove unused function 'IsInPictureInPictureMode()'. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/dfc019b0d561
part4 : test 'NotifyMediaFullScreenState()' in gTest. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/181b121b990a
part5 : request to become a main controller when controller enters fullscreen. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/eb6f3ddbda21
part6 : refine the logic of requesting main controller. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/bb318cb201e2
part7 : add test cases for choosing main controller. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/27e33cb31984
part8 : add test cases to ensure non-eligible media can be controlled when it enters fullscreen or PIP mode. r=chunmin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3728c4bb8101
Fix bustages caused by the backout of Bug 1200896 and conflicting changes to NotifyFullScreenChangedForMediaElement. a=bustage-fix

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1bcee92cca2f
https://hg.mozilla.org/mozilla-central/rev/a38035f87274
https://hg.mozilla.org/mozilla-central/rev/d250ac96b75f
https://hg.mozilla.org/mozilla-central/rev/dfc019b0d561
https://hg.mozilla.org/mozilla-central/rev/181b121b990a
https://hg.mozilla.org/mozilla-central/rev/eb6f3ddbda21
https://hg.mozilla.org/mozilla-central/rev/bb318cb201e2
https://hg.mozilla.org/mozilla-central/rev/27e33cb31984
https://hg.mozilla.org/mozilla-central/rev/3728c4bb8101