1654678 - Unify macOS and Linux CUPS data retrieval for nsIPrinterList

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P1)

Description

[Erik Nordin [:nordzilla]]

Up until now macOS has used the Core printing API, and Linux has used the GTK API for retrieving printer information.

With updates to our support for CUPS, introduced in Bug 1653433 we can now unify how both platforms retrieve printer information.

This patch will aim to refactor the existing functionality (retrieving printer names and paper sizes) on macOS and GTK to take advantage of these changes using the same code.

Comment 1

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1654678 Part 1 - Add generic CUPS printer interface

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88751d3ef57f
Part 1 - Add generic CUPS printer interface r=nordzilla

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/88751d3ef57f

Comment 4

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1654678 Part 2 - Make CUPSPrinter own its CUPS dest data

Comment 5

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1654678 Part 3 - Create nsPrinterCUPS and use it on OS X for printer enumeration

This leaves the nsPrinter for the time being, as it will also need to be
replaced on GTK before it can be removed.

While messing with widget/moz.build, also move the new printing source to be
controlled by the NS_PRINTING flag.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6749d961bb78
Part 2 - Make CUPSPrinter own its CUPS dest data r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/c09b32d23fd2
Part 3 - Create nsPrinterCUPS and use it on OS X for printer enumeration r=nordzilla

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6749d961bb78
https://hg.mozilla.org/mozilla-central/rev/c09b32d23fd2

Comment 8

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1654678 Part 4 - Make GTK printer enumeration use the unified CUPS code

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a98d688af751
Part 4 - Make GTK printer enumeration use the unified CUPS code r=jwatt,emilio

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a98d688af751

Comment 12

[Erik Nordin [:nordzilla]]

Marking resolved, since all patches have landed.