1654764 - Crash in [@ mozilla::net::DocumentChannel::GetContentType]

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect)

Description

[Simon Giesecke [:sg] [he/him]]

This bug is for crash report bp-178b428e-270e-4817-b76c-0dfe10200722.

Top 10 frames of crashing thread:

0 xul.dll mozilla::net::DocumentChannel::GetContentType netwerk/ipc/DocumentChannel.cpp:356
1 xul.dll nsPluginStreamListenerPeer::OnStartRequest dom/plugins/base/nsPluginStreamListenerPeer.cpp:160
2 xul.dll nsObjectLoadingContent::OnStartRequest dom/base/nsObjectLoadingContent.cpp:950
3 xul.dll mozilla::net::DocumentChannel::ShutdownListeners netwerk/ipc/DocumentChannel.cpp:94
4 xul.dll mozilla::net::DocumentChannelChild::Cancel netwerk/ipc/DocumentChannelChild.cpp:364
5 xul.dll mozilla::net::nsLoadGroup::Cancel netwerk/base/nsLoadGroup.cpp:230
6 xul.dll nsDocLoader::Stop uriloader/base/nsDocLoader.cpp:253
7 xul.dll nsDocShell::Stop docshell/base/nsDocShell.cpp:3980
8 xul.dll nsDocShell::Destroy docshell/base/nsDocShell.cpp:4177
9 xul.dll nsWebBrowser::SetDocShell toolkit/components/browser/nsWebBrowser.cpp:1131

Crashes with this signature started on Nightly build id 20200721094241.

Dan, might this be a regression from Bug 1646899?

Comment 1

[u480271]

Attachment: Bug 1654764: Reduce DocumentChannel::GetContentType() crash to error. r?mattwoodrow

Comment 2

[u480271]

Looks like nsPluginStreamListenerPeer::OnStartRequest handles nsIChannel::GetContentType but DocumentChannel is being a bit opinionated about not implementing all of nsIChannel's interface.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/018034204705
Reduce DocumentChannel::GetContentType() crash to error. r=mattwoodrow

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/018034204705

Comment 5

[Julien Cristau [:jcristau] (back August 18)]

Please request beta uplift when you get a chance.

Comment 6

[u480271]

Comment on attachment 9166467 [details]
Bug 1654764: Reduce DocumentChannel::GetContentType() crash to error. r?mattwoodrow

Beta/Release Uplift Approval Request

• User impact if declined: Tab could crash from a diagnostic assert if the user accesses a plugin
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change reduces a MOZ_ASSERT used as a diagnostic to a warning with error, which the API already supports so the callers should be prepared for error.
• String changes made/needed: None

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9166467 [details]
Bug 1654764: Reduce DocumentChannel::GetContentType() crash to error. r?mattwoodrow

approved for 80.0b3

Comment 8

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/8bca8bdf131e