1646899 - Use DocumentChannel to for object/embed loads - Pt 1

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[u480271]

Part one - Plumb channel creation through DocumentChannel for <embed> & <object> elements. Redirect channel directly to content to effect a different mechanism for channel creation, but keep decision making in content.

Part two - Move decision making into parent process. Eg. cross-origin documents loaded via <object> need to create a new process, BrowsingContext, etc.

Comment 1

[u480271]

Attachment: Bug 1646899 - P1: Deduplicate initialization of LoadInfo default values.

LoadInfo has a lot of state. Simplify initialization so most have one definition
of truth.

Comment 2

[u480271]

Attachment: Bug 1646899 - P2: Use named factories to create LoadInfo.

LoadInfo has a number of constructors intended to be used in different contexts.
Add named factory functions to make it clearer in which context the returns
LoadInfo is being used.

Comment 3

[u480271]

Attachment: Bug 1646899 - P3: Modify CanUseDocumentChannel to take necessary vars.

Allows checking if DocumentChannel can be used with out creating an
nsDocShellLoadState object.

Comment 4

[u480271]

Attachment: Bug 1646899 - P4: Handle object & embed via DocumentChannel.

Pass internal content policy type to DLL and switch behavior depending on type
being loaded. This implementation immediately redirects channel back to the
content process for further handling.

Comment 5

[u480271]

Attachment: Bug 1646899 - P5: Fix test_bug375314.

test_bug375314 - Move check from content to parent process.
iframe-scrolling-attribute-values.html - Update from permafail on linux debug to
intermittent.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4731d76dae88
P1: Deduplicate initialization of LoadInfo default values. r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/7a7194146fe1
P2: Use named factories to create LoadInfo. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/d2fd0f955e24
P3: Modify CanUseDocumentChannel to take necessary vars. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/86a5e0827050
P4: Handle object & embed via DocumentChannel. r=mattwoodrow,jya
https://hg.mozilla.org/integration/autoland/rev/f41ac122a801
P5: Fix test_bug375314. r=heycam

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on DocumentLoadListener.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/2c8bc998c107bd6a6182b5fc4740fe77fc07cfca
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309539240&repo=autoland&lineNumber=2666

Comment 9

[u480271]

Matt, Patch 4 might need another once over. I removed the use of mExternalContentPolicyType, set in Open(), to switch document/object logic and added a boolean mIsDocumentLoad that makes it a little clearer.

Comment 10

[Matt Woodrow (:mattwoodrow)]

Looks good!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c593013b710
P1: Deduplicate initialization of LoadInfo default values. r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/fc96ea4de326
P2: Use named factories to create LoadInfo. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/64e118a38c1d
P3: Modify CanUseDocumentChannel to take necessary vars. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/41de9ac734d6
P4: Handle object & embed via DocumentChannel. r=mattwoodrow,jya
https://hg.mozilla.org/integration/autoland/rev/94dcb2fb29ce
P5: Fix test_bug375314. r=heycam

Comment 12

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6c593013b710
https://hg.mozilla.org/mozilla-central/rev/fc96ea4de326
https://hg.mozilla.org/mozilla-central/rev/64e118a38c1d
https://hg.mozilla.org/mozilla-central/rev/41de9ac734d6
https://hg.mozilla.org/mozilla-central/rev/94dcb2fb29ce