1654903 - Perma browser/components/pioneer/test/browser/browser_pioneer_ui.js | after clicking enrollment, consent dialog is open. - when Gecko 80 merges to Beta on 2020-07-27

Status: RESOLVED FIXED

(Firefox :: Pioneer, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=28460f5682b430c9da8c6c99a54574037cfb6b30&searchStr=browser-chrome&selectedTaskRun=azCx_vJKTRi3v5dQD0uGKQ.0

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=310842160&repo=try

[task 2020-07-23T13:21:25.018Z] 13:21:25 INFO - TEST-PASS | browser/components/pioneer/test/browser/browser_pioneer_ui.js | before enrollment, Pioneer toolbar button is hidden. -
[task 2020-07-23T13:21:25.019Z] 13:21:25 INFO - Buffered messages finished
[task 2020-07-23T13:21:25.019Z] 13:21:25 INFO - TEST-UNEXPECTED-FAIL | browser/components/pioneer/test/browser/browser_pioneer_ui.js | after clicking enrollment, consent dialog is open. -
[task 2020-07-23T13:21:25.020Z] 13:21:25 INFO - Stack trace:
[task 2020-07-23T13:21:25.020Z] 13:21:25 INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2020-07-23T13:21:25.020Z] 13:21:25 INFO - chrome://mochitests/content/browser/browser/components/pioneer/test/browser/browser_pioneer_ui.js:testAboutPage:90

Comment 1

[Robert Helmer [:rhelmer]]

Ah shoot the <dialog> element is still experimental (it has been released on other browsers but experimental only in Firefox for years apparently but there's recent activity): https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features

Google has a polyfill that looks OK and is under a liberal license: https://github.com/GoogleChrome/dialog-polyfill

Mark, wdyt about using a polyfill vs. implementing this a different way? IIRC Preferences uses XUL but I'd rather avoid it if possible.

Comment 2

[Robert Helmer [:rhelmer]]

Attachment: Bug 1654903 - add polyfill for dialog element r?mstriemer

Comment 3

[Cosmin Sabou [:CosminS]]

Robert, patch is working in beta-sims: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&author=nbeleuzu%40mozilla.com&tochange=c0f80bf83b758ea27e0c0f6a019359022642eb6f&fromchange=b1767dec37331902b2de3a50a01ecf1eb4a65a77&searchStr=bc&test_paths=browser%2Fcomponents%2Fpioneer%2Ftest%2Fbrowser%2F&selectedTaskRun=avRPJ03tS8KFJ2Xrn_D_Lg.0

Comment 4

[Robert Helmer [:rhelmer]]

(In reply to Cosmin Sabou [:CosminS] from comment #3)

Robert, patch is working in beta-sims: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&author=nbeleuzu%40mozilla.com&tochange=c0f80bf83b758ea27e0c0f6a019359022642eb6f&fromchange=b1767dec37331902b2de3a50a01ecf1eb4a65a77&searchStr=bc&test_paths=browser%2Fcomponents%2Fpioneer%2Ftest%2Fbrowser%2F&selectedTaskRun=avRPJ03tS8KFJ2Xrn_D_Lg.0

Awesome, thanks for the confirmation! Bringing in a polyfill for this is kind of annoying, but I think it's better than using XUL or something custom... it'll be easy to remove it if/when Firefox ships the latest <dialog> standard.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

If Mark is busy or on PTO, can a different person review the patch?

Comment 6

[Intermittent Failures Robot]

1 failures in 4289 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• linux1804-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1654903&startday=2020-07-27&endday=2020-08-02&tree=all

Comment 7

[Robert Helmer [:rhelmer]]

The plan to unblock this is to enabled <dialog> for chrome-only code in Firefox 80, the primary reason it's disabled with now is an a11y issue (bug 1200896). However, we can work around this issue for 80 with a JS focus hack. I'll set the bug blocking when it's filed / I find it :)

Comment 8

[Robert Helmer [:rhelmer]]

The problem with the current patch is that this polyfill has the same a11y problem, so there's not really any point to doing this vs. just enabling native <dialog> for chrome-only code, so I am going to abandon this and will have a new one ASAP.

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Given bug 1657163 is now in 80, can we close this one?

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's central-as-beta simulation and on beta with https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=3649c4dd0f883b3487fa307b1fd036349a09209e

Comment 11

[Intermittent Failures Robot]

1 failures in 4618 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1654903&startday=2020-08-03&endday=2020-08-09&tree=all