1657163 - Enable <dialog> in chrome UI for beta/release

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Brian Grinstead [:bgrins]]

The about:pioneer UI would like to use <dialog> in 80, and after discussing with the relevant teams we decided that it'd make sense to uplift a change that allows the use of <dialog> in chrome UI only.

The pioneer team will separately work around Bug 1200896 using JS in the frontend to resolve an existing accessibility concern.

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1657163 - Enable <dialog> in chrome UI for beta/release r=smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1735ab181b5
Enable <dialog> in chrome UI for beta/release r=smaug

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d1735ab181b5

Comment 4

[Sean Feng [:sefeng]]

Attachment: beta_uplift_request

The attached patch is the one that we want to apply.

Approval Request Comment
[Feature/Bug causing the regression]: This is not a regression. Bug 1653098 uses <dialog>, however, this is only enabled in Nightly. This bug exposes the feature to all channels for chrome.
[User impact if declined]: about:pioneer is not going to work properly for beta and release users.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This patch only exposes <dialog> to chrome, which is not risky.
[String changes made/needed]:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9168246 [details]
beta_uplift_request

FYI, you can just request approval on the attachment directly rather than putting it on a separate attachment.

Approved for 80.0b5.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3649c4dd0f88

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #26680 (as of Sun, 09 Aug 2020 20:15:01 GMT) ==

Improvements:

7% build times linux64 debug base-toolchains-clang taskcluster-c5.4xlarge 1,444.15 -> 1,349.22

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26680