1655010 - [V2 Doorhanger] Logins from different subdomains are not suggested in the username suggestion dropdown

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Recording of the issue

Affected Versions:
Nightly 80.0a1 - since Bug 1641413 was landed and should've offered base domain and subdomain suggestions

Tested on:
Windows 10

Steps to reproduce:

1. Have saved credentials on facebook subomains, such as:

• ro-ro.facebook.com
• fr-fr.facebook.com

2. Have saved credential on Facebook.com (Base Domain)
3. Load Facebook.com and type in the username and password field
4. Open the dismissed doorhanger and check the suggested usernames list

Expected:
Credential saved on facebook subdomains should've been also displayed for username suggestion, not just the base domain.

Actual:
Only the username saved on the base domain (Facebook.com) is suggested.

Regression-range:
Not a regression, more like partial implementation of Bug 1641413

Notes:
This is also reproducible with subdomain, ex:

• on fr-fr.facebook.com only the username for this subdomain is shown as suggestion

Comment 1

[Matthew N. [:MattN]]

I think we just need acceptDifferentSubdomains: true at https://searchfox.org/mozilla-central/rev/56bb74ea8e04bdac57c33cbe9b54d889b9262ade/toolkit/components/passwordmgr/LoginManagerPrompter.jsm#1018-1021

Comment 2

[:severin Rudie]

Attachment: Bug 1655010 - pmgr doorhanger now suggests logins from different subdomains;r=MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7157682306ea
pmgr doorhanger now suggests logins from different subdomains;r=MattN

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7157682306ea

Comment 5

[Andrei Purice]

Reproduced on 80.0a1 (20200724093206) on Windows 10 x64.
Verified > Fixed on 81.0a1 (20200807093158) on Windows 10 x64.

Comment 6

[Julien Cristau [:jcristau]]

Do we need this in 80?

Comment 7

[:severin Rudie]

Attachment: Beta uplift request for `Bug 1655010 - pmgr doorhanger now suggests logins from different subdomains;r=MattN`

Approval Request Comment
[Feature/Bug causing the regression]: Not a regression, defect from Bug 1641413 implementation
[User impact if declined]: pmgr doorhanger will not suggest usernames from logins saved on different subdomains.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Trivial change, using an already well-used code path. Covered by automated tests.
[String changes made/needed]: None

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9168307 [details]
Bug 1655010 - pmgr doorhanger now suggests logins from different subdomains;r=MattN

approved for 80.0b7

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ddb63acb82aa

Comment 10

[Andrei Purice]

Verified > Fixed on 80.0b8 (20200813191622) on Windows 10 x64.