1641413 - [Doorhanger V2] Show all base domain logins in doorhanger

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[:severin Rudie]

We are not always able to determine which login should be updated when a user changes a password on a site for which they have multiple logins. This can lead to duplicated accounts in the password manager. We should show all saved logins for the current page and allow the user to select which, if any, are to be updated. By default, the login that we believe to be the most likely target should be displayed.

Technical notes -

• The doorhanger is shown from LoginManagerPrompter#_showLoginCaptureDoorhanger. This method already has access to the current origin (through a passed login) and login storage (through LoginHelper).
• Select the value that's already being passed through as a default.

Comment 1

[:severin Rudie]

Attachment: Bug 1641413 - show all UNs from domain in the username field of the password manager doorhanger;r=MattN

Depends on D80673

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/373916f95ddd
show all UNs from domain in the username field of the password manager doorhanger;r=MattN

Comment 3

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=55203e84a6a1cbb0abbb5548689d6f550f674715&failure_classification_id=2

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310097485&repo=autoland&lineNumber=21574

Backout: https://hg.mozilla.org/integration/autoland/rev/a3bf7a21c023e7bf341ae7d7f6cdeb84439436ff

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1710b1714f8d
show all UNs from domain in the username field of the password manager doorhanger;r=MattN

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1710b1714f8d

Comment 6

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on latest Firefox Nightly 80.0a1 (2020-07-20) (64-bit) on Windows 10, MacOS 10.13 and Ubuntu 16.04.
The saved logins for a base domain are now also offered as a suggestion in the dropdown and differentiated by the grey key icon.