Closed Bug 1641413 Opened 4 months ago Closed 2 months ago

[Doorhanger V2] Show all base domain logins in doorhanger

Categories

(Toolkit :: Password Manager, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
mozilla80
Tracking Status
firefox80 --- verified

People

(Reporter: severin, Assigned: severin)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

We are not always able to determine which login should be updated when a user changes a password on a site for which they have multiple logins. This can lead to duplicated accounts in the password manager. We should show all saved logins for the current page and allow the user to select which, if any, are to be updated. By default, the login that we believe to be the most likely target should be displayed.

Technical notes -

  • The doorhanger is shown from LoginManagerPrompter#_showLoginCaptureDoorhanger. This method already has access to the current origin (through a passed login) and login storage (through LoginHelper).
  • Select the value that's already being passed through as a default.
Assignee: nobody → severin.mozilla
Status: NEW → ASSIGNED
Attachment #9158584 - Attachment description: Bug 1641413 - show all UNs from domain in password manager doorhanger v2;r=MattN → Bug 1641413 - show all UNs from domain in the username field of the password manager doorhanger;r=MattN
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/373916f95ddd
show all UNs from domain in the username field of the password manager doorhanger;r=MattN
Pushed by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1710b1714f8d
show all UNs from domain in the username field of the password manager doorhanger;r=MattN
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Flags: needinfo?(severin.mozilla)
Blocks: 1154763

Verified-fixed on latest Firefox Nightly 80.0a1 (2020-07-20) (64-bit) on Windows 10, MacOS 10.13 and Ubuntu 16.04.
The saved logins for a base domain are now also offered as a suggestion in the dropdown and differentiated by the grey key icon.

Status: RESOLVED → VERIFIED
See Also: → 1655010
Blocks: 1655505
Regressions: 1659655
You need to log in before you can comment on or make changes to this bug.