1655066 - Search Engine icons should be indexed by width only

Status: RESOLVED FIXED

(Firefox :: Search, defect, P3)

Description

[Mark Banner (:standard8)]

Currently SearchEngine stores icons according to their width and height. Given that they're assumed to be the same as favicons, I think we should:

• Throw away any icons which have a different width/height (this would only really affect broken OpenSearch configurations).
• Store and retrieve icons by width.

Using the width would make the icon store behave similarly to nsFaviconService making us more consistent and the code simpler.

The current code has the problems that:

• the width/height can sometimes be strings and sometimes be numbers, that causes _getIconKey to return different keys due to its use of JSON.stringify.
• _initFromManifest currently attempts to set the size of the icon from the manifest, but sets the width/height in one place, and uses icon.size in another, which means we add an icon to the map with no size information, as that is undefined.

We should make sure we fix and add tests for those as part of this bug.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:standard8, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 1655066 - Search Engine icons should be indexed by width only. r?standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27f9666d2533
Search Engine icons should be indexed by width only. r=Standard8

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/27f9666d2533