1655200 - checks for values in browser/base/content/test/tabs/browser_multiselect_tabs_mute_unmute.js are broken or duplicated

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

In bug 1647187, we are working to change is() to be object.is(). This means changing a lot of tests. We have fixed almost all the tests and one of the last tests to get fixed is:
browser/base/content/test/tabs/browser_multiselect_tabs_mute_unmute.js

the problem is in head.js:
https://searchfox.org/mozilla-central/source/browser/base/content/test/tabs/head.js#180

we get into:

      if (expectMuted || everMutedTabs.has(tab)) {
        everMutedTabs.add(tab);
        is(tab.muteReason, null, "The tab should have a null muteReason value");
      } else {
        is(
          tab.muteReason,
          undefined,
          "The tab should have an undefined muteReason value"
        );
      }

and we end up in the else condition with tab.muteReason=null and not undefined.

Typically I would change the value, but this test specifically checks for null AND undefined, so I need someone who understands this to look into it.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Abdoulaye this was added in bug 1470677, do you know if we should have both a check for null and undefined? Maybe you have more background

Comment 2

[Abdoulaye O. LY]

Yes, we should have both checks. I will have a look a this.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

thanks, if you look at Object.is() or === instead of is() which uses ==, that will show the error.

Comment 4

[Abdoulaye O. LY]

Attachment: Bug 1655200 - Make sure that every muted tab in browser_multiselect_tabs_mute_unmute.js file is added to the set of muted tabs.

Comment 5

[Abdoulaye O. LY]

@jmaher: We need to find a reviewer for this. Maybe @dao can help?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for fixing this so fast.

I wouldn't know who to review, :jaws will be back next week if :dao doesn't have a recommendation.

Comment 7

[Dão Gottwald [:dao]]

I r+'d the patch.

Comment 8

[Abdoulaye O. LY]

(In reply to Dão Gottwald [::dao] from comment #7)

I r+'d the patch.

Thank you!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ea9fc3e7a58
Make sure that every muted tab in browser_multiselect_tabs_mute_unmute.js file is added to the set of muted tabs. r=dao

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6ea9fc3e7a58