1655367 - nsprpub/pr/src/linking/prlink.c:810:17 [-Wimplicit-int] type specifier missing, defaults to 'int'

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Chris Peterson [:cpeterson]]

This new -Wimplicit-int clang warning on macOS is a regression in NSPR 4.27 from bug 1652330:

nsprpub/pr/src/linking/prlink.c:810:17 [-Wimplicit-int] type specifier missing, defaults to 'int'

The declaration const name_len = strlen(name); is missing a type specifier. The type should presumably be size_t like systemPrefixLen1 and systemPrefixLen2 above it.

https://searchfox.org/mozilla-central/rev/cf561cece0ca9aeaf0202e68699836d957d0c670/nsprpub/pr/src/linking/prlink.c#810

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1655367 - Use an explicit type for name_len, avoid int type warning. r=cpeterson

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:KaiE, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #2)

The severity field is not set for this bug.

Setting severity S4. This code warning should be fixed, but doesn't cause any user-visible problems.

Comment 4

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nspr/rev/52b4a7eb43759ea7b02ba69cbf69a3fd9bde9d79