Closed Bug 1655400 Opened 1 year ago Closed 1 year ago

Enable ESLint rule no-setter-return for all of places

Categories

(Toolkit :: Places, task, P3)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: standard8, Assigned: soniasingla, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

We'd like to enable the ESLint rule, no-setter-return, for all of */places/*.

To help Mozilla out with this bug, here's the steps:

  1. Use this as a general guide for how to contribute whilst following these steps: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
  2. Start working on this bug, we'll assign it when the first patch is assigned. Though you can comment that you're working on it if you wish.
  3. Build your change with ./mach build and test your change with:
    • ./mach xpcshell-test toolkit/components/places
    • ./mach mochitest browser/component/places
  4. Submit the patch for review. Mark me as a reviewer (r?standard8) so I'll get an email to come look at your code.
  5. After a series of reviews and changes to your patch, I'll approve your patch and push it to our integration branch autoland. If no issues are raised, the bug will then be marked as fixed within a day. Your code will soon be shipping to Firefox users worldwide!
  6. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

I am working on this, thanks !

Assignee: nobody → soniasingla.1812
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b87c49182a4
Enable ESLint rule no-setter-return for all of places. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.