1655400 - Enable ESLint rule no-setter-return for all of places

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Mark Banner (:standard8)]

We'd like to enable the ESLint rule, no-setter-return, for all of */places/*.

To help Mozilla out with this bug, here's the steps:

1. Use this as a general guide for how to contribute whilst following these steps: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
   • If you have any problems, please ask on Matrix (https://wiki.mozilla.org/Matrix) in the #introduction channel. They're there to help you get started.
2. Start working on this bug, we'll assign it when the first patch is assigned. Though you can comment that you're working on it if you wish.
   • Remove the relevant lines from the top-level .eslintrc.js
     • Note: There's a toolkit entry further down as well.
   • Run ./mach eslint browser toolkit
   • Fix the issues with the rule, details about the rule can be found here: https://eslint.org/docs/rules/no-setter-return
3. Build your change with ./mach build and test your change with:
   • ./mach xpcshell-test toolkit/components/places
   • ./mach mochitest browser/component/places
4. Submit the patch for review. Mark me as a reviewer (r?standard8) so I'll get an email to come look at your code.
5. After a series of reviews and changes to your patch, I'll approve your patch and push it to our integration branch autoland. If no issues are raised, the bug will then be marked as fixed within a day. Your code will soon be shipping to Firefox users worldwide!
6. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Comment 1

[Sonia Singla :soniasingla]

I am working on this, thanks !

Comment 2

[Sonia Singla :soniasingla]

Attachment: Bug 1655400 - Enable ESLint rule no-setter-return for all of places. r=standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b87c49182a4
Enable ESLint rule no-setter-return for all of places. r=Standard8

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3b87c49182a4