Closed Bug 1620552 Opened 4 years ago Closed 3 years ago

[meta] Enable ESLint rule no-setter-return

Categories

(Developer Infrastructure :: Lint and Formatting, task, P2)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: standard8, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: meta)

From the ESLint page for no-setter-return:

Setters cannot return values.
While returning a value from a setter does not produce an error, the returned value is being ignored. Therefore, returning a value from a setter is either unnecessary or a possible error, since the returned value cannot be used.

This rule is being turned on by default in ESLint 7, and it seems useful to have, as we have quite a few cases throughout the tree where we're returning things unnecessarily.

No longer blocks: 1620537
Depends on: 1620537

This is going to be a meta for once the ESLint 7 changes have landed.

Keywords: meta
Summary: Enable ESLint rule no-setter-return → [meta] Enable ESLint rule no-setter-return
Depends on: 1655400
Blocks: 1596191
Depends on: 1687235

This is now fully enabled.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.