1655452 - Snippet error state redirects to wrong retry scene

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Andrei Oprea [:andreio]]

Form error state for new snippet does not redirect to the correct retry scene.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1655452 - Snippet error state redirects to wrong retry scene

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5ad6447a965
Snippet error state redirects to wrong retry scene r=k88hudson

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a5ad6447a965

Comment 4

[Andrei Oprea [:andreio]]

Comment on attachment 9166526 [details]
Bug 1655452 - Snippet error state redirects to wrong retry scene

Beta/Release Uplift Approval Request

• User impact if declined: Affects users that interact with the feature: error state is not properly handled, minor UI tweaks.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Covered by test. Verified in Nightly by myself and Giorgos on the snippets side (not by QA).
• String changes made/needed:

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9166526 [details]
Bug 1655452 - Snippet error state redirects to wrong retry scene

approved for 80.0b3

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe1703ad00e8

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (81.0a1 Build ID - 20200809213940) and the latest Firefox Beta (80.0b6 Build ID - 20200807195315) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15. Now, using the "SNIPPETS_SCENE2_SEND_TO_DEVICE_TEST" template snippet, I can confirm that the snippet error state redirects to the correct scene.