1655709 - Don't listen for shared worker targets in content toolbox.

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Support for SharedWorker debugging in the content toolbox will be handled in Bug 1607778.
But the LegacySharedWorkerWatcher doesn't do any check, and ends up calling listWorkers (devtools/server/actors/targets/browsing-context.js#747), which will end up creating a WorkerTargetListActor (browsing-context.js#731,733-736,754), where we only watch for dedicated workers.

Having that being triggered as part of the SharedWorker listener in content toolbox can cause trouble, especially if/when we listen for dedicated worker targets by other means than the WorkerTargetListActor (like in Bug 1633712).

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1655709 - Don't listen for shared workers in content toolbox. r=ochameau.

Support for SharedWorker debugging in the content toolbox will be handled in Bug 1607778.
But the LegacySharedWorkerWatcher doesn't do any check, and ends up calling listWorkers
on the browsing context target actor, which creates a WorkerTargetListActor
where we only care about dedicated worker.

Having that being triggered as part of the SharedWorker listener in content toolbox
can cause issues, especially if/when we listen for dedicated worker targets by
other means than the WorkerTargetListActor (like in Bug 1633712).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7342cba67e60
Don't listen for shared workers in content toolbox. r=ochameau.

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7342cba67e60