1655867 - Port bug 1635662 - Add ecosystemClientId to the Accounts Ecosystem Telemetry ping

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Geoff Lankow (:darktrojan)]

TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_client_id.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryController.js | xpcshell return code: 0 

Comment 1

[Geoff Lankow (:darktrojan)]

These tests are failing but pass with the overrideProductsCheck pref set. So I assume they'd pass with Thunderbird added to the products for the new scalar. Trying that as soon as I have a working build again.

Comment 2

[Lina Butler (ex-Mozilla)]

Oops, sorry about that! I wonder if it would be better to add a AppConstants.MOZ_APP_NAME != "thunderbird" condition to these branches (is that a legit MOZ_APP_NAME?), like we do for Android. WDYT?

Comment 3

[Geoff Lankow (:darktrojan)]

That makes sense, I assume that comment about Android also applies to us (since we don't have FxA etc.).

Which leaves test_TelemetryController.js:

TypeError: can't access property "deletion.request.ecosystem_client_id", ping.payload.scalars.parent is undefined at /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/telemetry/tests/unit/test_TelemetryController.js:324

Should we just skip that bit too?

Comment 4

[Lina Butler (ex-Mozilla)]

(In reply to Geoff Lankow (:darktrojan) from comment #3)

Should we just skip that bit too?

Yes please!

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1655867 - Skip parts of telemetry tests that are irrelevant to Thunderbird. r?lina

Comment 6

[Geoff Lankow (:darktrojan)]

Thanks for your help!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48d55a4eb97a
Skip parts of telemetry tests that are irrelevant to Thunderbird. r=lina

Comment 8

[Intermittent Failures Robot]

28 failures in 864 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 28

Platform breakdown:

• linux64-shippable: 3
• windows10-64-shippable: 3
• windows7-32-shippable: 3
• macosx1014-64-shippable: 3
• linux64: 4
• windows10-64: 4
• windows7-32: 4
• macosx1014-64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1655867&startday=2020-07-28&endday=2020-07-28&tree=all

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/48d55a4eb97a

Comment 10

[Intermittent Failures Robot]

40 failures in 4289 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

This is the #30 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 40

Platform breakdown:

• linux64-shippable: 4
• windows10-64-shippable: 4
• windows7-32-shippable: 4
• macosx1014-64-shippable: 4
• linux64: 6
• windows10-64: 6
• windows7-32: 6
• macosx1014-64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1655867&startday=2020-07-27&endday=2020-08-02&tree=all