1655884 - "Always prefer display name over message header" checkbox is always checked

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

I think this got broken when we first linted abCard.js. We made one attempt to fix it at the time but it's still broken.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1655884 - Fix "Always prefer display name over message header" checkbox. r?aleca

This puts the line back to how it was before we added linting. Obviously the linting change and the follow-up fix were both bogus.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7405c52008fe
Fix "Always prefer display name over message header" checkbox. r=aleca

Comment 3

[Wayne Mery (:wsmwk)]

Comment on attachment 9166718 [details]
Bug 1655884 - Fix "Always prefer display name over message header" checkbox. r?aleca

[Triage Comment]
Approved for beta

Comment 4

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/e669b14b4f3b

Comment 5

[WaltS48 [:walts48]]

Looks good to me in my testing of the 80.0b2 release candidate on Ubuntu 18.04.4.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9166718 [details]
Bug 1655884 - Fix "Always prefer display name over message header" checkbox. r?aleca

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/12d95f4c66b9

Comment 8

[WaltS48 [:walts48]]

Still being always checked in my testing of the 78.2.0 release candidate on Ubuntu 18.04.5 LTS. New profile.

Helps to test the correct build.

Comment 9

[Thomas D. (:thomas8)]

Well, maybe we should clarify the desired behaviour first because imho the design is inherently garbled and mutilated.
We have a global pref controlling the same behaviour: Show only display name for people in my address book.
Iiuc, here we have a per-card pref which is supposed to override the global behaviour.
If I don't change the card pref, it should use the global default, isn't it?
So what is the difference in UI state between per-card custom setting and "use global setting"? Can't tell.

Clearly, the interaction of global and per-card pref can never work correctly and predictably unless per-card pref is triple:

• Use global pref
• Prefer display name from address book over message header
• Prefer message header over address book display name
  Internally, use a number pref which can be set to 0, 1, and 2.

And what if I want the display name from my AB AND the email address?