1655953 - Remove the mutex for padding file

Status: RESOLVED FIXED

(Core :: Storage: Cache API, enhancement, P2)

Description

[Tom Tung [:tt, :ttung]]

See: https://phabricator.services.mozilla.com/D80823#2631981

We need the mutex for the padding file because it can be accessed on the main thread and the Cache IO thread (one per origin).

We need to access it on the main thread because:

1. InitOrigin
2. GetUsage

(1) doesn't really matter because when we are there, the cache IO thread shouldn't have existed yet.

(2) is going to be removed by getting the cached usage in D80823.

So, hopefully, we can remove the mutex.

Comment 1

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1655953 - Remove mutex lock for protecting the padding file;

Comment 2

[Tom Tung [:tt, :ttung]]

I will update patches for:

• Revise padding functions
• Consider using CACHE_TRY for padding functions or CacheQuotaClient::InitOrigin.
  • I will need to check if there will have too many warnings when there are failures.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d05d2e1fc2a1
Remove mutex lock for protecting the padding file; r=dom-workers-and-storage-reviewers,sg,asuth,janv

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d05d2e1fc2a1