1647316 - Have a test like dom/localstorage/test/unit/test_originInit.js for DOM Cache to test padding files and database

Status: RESOLVED FIXED

(Core :: Storage: Cache API, task, P2)

Description

[Tom Tung [:tt, :ttung]]

See details in https://phabricator.services.mozilla.com/D80001

"it would be better to have a standalone test for this in dom/cache/test/xpcshell, similar to https://searchfox.org/mozilla-central/rev/1304678d837c17811617754fd446794b774afe94/dom/localstorage/test/unit/test_originInit.js"

Note that Jan also suggested a way to create storage for named origin in DOM Cache:
"I think I found a solution how to create DOM cache for a named origin (using a sandbox):
https://searchfox.org/mozilla-central/rev/1304678d837c17811617754fd446794b774afe94/dom/quota/test/xpcshell/make_unknownFiles.js#106"

Comment 1

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1647316 - Have a test to ensure origin initialization should succeed;

Comment 2

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1647316 - Align the InitOrigin for Cache with other client's;

Depends on D80822

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1647316 - Revert the change for test_initTemporaryStorage.js since we have test_originInit.js;

Depends on D80823

Comment 4

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1647316 - Treat all usages in DOM Cache as database usages;

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4ce5e1ff2e2
Have a test to ensure origin initialization should succeed; r=dom-workers-and-storage-reviewers,janv,sg
https://hg.mozilla.org/integration/autoland/rev/f9b28a22bc19
Treat all usages in DOM Cache as database usages; r=dom-workers-and-storage-reviewers,sg

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d4ce5e1ff2e2
https://hg.mozilla.org/mozilla-central/rev/f9b28a22bc19

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:tt, maybe it's time to close this bug?

Comment 8

[Tom Tung [:tt, :ttung]]

We can close this bug once D80823 and D80824 are landed. At the moment, D80823 hasn't been reviewed yet. :)

Comment 9

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1647316 - Update expected file layout for test_originMismatch since the padding file will be removed if the caches.sqlite doesn't exist after initializing;

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/594560c6b278
Align the InitOrigin for Cache with other client's; r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/1f2481edad7a
Revert the change for test_initTemporaryStorage.js since we have test_originInit.js; r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/3fde1586e802
Update expected file layout for test_originMismatch since the padding file will be removed if the caches.sqlite doesn't exist after initializing; r=dom-storage-reviewers,janv

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/594560c6b278
https://hg.mozilla.org/mozilla-central/rev/1f2481edad7a
https://hg.mozilla.org/mozilla-central/rev/3fde1586e802

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?

Comment 13

[Jens Stutte [:jstutte]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #12)

:jstutte, maybe it's time to close this bug?

Is it, Jan?

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:jstutte, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:edenchuang, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 16

[Eden Chuang[:edenchuang]]

I have no idea why the leave-open flag is still there.
It seems we can remove the leave-open flag and close it.

Comment 17

[Jan Varga [:janv]]

(In reply to Jens Stutte [:jstutte] from comment #13)

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #12)

:jstutte, maybe it's time to close this bug?

Is it, Jan?

The remaining work has been done in bug 1706350 I think.