Closed Bug 1655982 Opened 4 years ago Closed 4 years ago

bug1655906.js | -e:1:26 SyntaxError: invalid escape sequence: (code 3, args "") [0.4 s]

Tracking

()

Status:

RESOLVED FIXED

Milestone:

81 Branch

Tracking Flags:

Tracking

Status

firefox-esr68

---

unaffected

firefox-esr78

---

unaffected

firefox79

---

unaffected

firefox80

---

unaffected

firefox81

---

fixed

People

(Reporter: intermittent-bug-filer, Assigned: jandem)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1655982 - Remove redundant skip-if from TypedObject jit-test. r?bc! 4 years ago Jan de Mooij [:jandem] 47 bytes, text/x-phabricator-request		Details \| Review

Treeherder Bug Filer

Reporter

Description

•

4 years ago

treeherder

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=311388282&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VBxS-XnwRFOgbgplU_KG9w/runs/0/artifacts/public/logs/live_backing.log

[task 2020-07-29T12:37:33.863Z] 12:37:31 bz_status_RESOLVED bz_closed" [task 2020-07-29T12:37:33.863Z] 12:37:31 [task 2020-07-29T12:37:33.863Z] 12:37:31 [task 2020-07-29T12:37:33.863Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 bz_status_VERIFIED bz_closed" [task 2020-07-29T12:37:33.864Z] 12:37:31 bz_status_VERIFIED bz_closed" [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:31 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 bz_status_VERIFIED bz_closed" [task 2020-07-29T12:37:33.864Z] 12:37:32 bz_status_VERIFIED bz_closed" [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 [task 2020-07-29T12:37:33.864Z] 12:37:32 bz_status_VERIFIED bz_closed" [task 2020-07-29T12:37:33.864Z] 12:37:32 bz_status_VERIFIED bz_closed" INFO - TEST-PASS | tests/jit-test/jit-test/tests/TypedObject/bug1510588.js | Success (code 0, args "--blinterp-eager") [0.5 s]
INFO - -e:1:26 SyntaxError: invalid escape sequence:
INFO - -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - -e:1:26 ..........................^-e:1:26 SyntaxError: invalid escape sequence:
INFO - -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - -e:1:26 ..........................^Exit code: 3
INFO - FAIL - TypedObject/bug1655906.js
WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/TypedObject/bug1655906.js | -e:1:26 SyntaxError: invalid escape sequence: (code 3, args "") [0.4 s]
INFO - INFO exit-status : 3
INFO - INFO timed-out : False
INFO - INFO stdout > -e:1:26 SyntaxError: invalid escape sequence:
INFO - INFO stdout > -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - INFO stdout > -e:1:26 ..........................^
INFO - INFO stderr 2> -e:1:26 SyntaxError: invalid escape sequence:
INFO - INFO stderr 2> -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - INFO stderr 2> -e:1:26 ..........................^
INFO - -e:1:26 SyntaxError: invalid escape sequence:
INFO - -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - -e:1:26 ..........................^-e:1:26 SyntaxError: invalid escape sequence:
INFO - -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - -e:1:26 ..........................^Exit code: 3
INFO - FAIL - TypedObject/bug1655906.js
WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/TypedObject/bug1655906.js | -e:1:26 SyntaxError: invalid escape sequence: (code 3, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.5 s]
INFO - INFO exit-status : 3
INFO - INFO timed-out : False
INFO - INFO stdout > -e:1:26 SyntaxError: invalid escape sequence:
INFO - INFO stdout > -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - INFO stdout > -e:1:26 ..........................^
INFO - INFO stderr 2> -e:1:26 SyntaxError: invalid escape sequence:
INFO - INFO stderr 2> -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - INFO stderr 2> -e:1:26 ..........................^
INFO - -e:1:26 SyntaxError: invalid escape sequence:
INFO - -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - -e:1:26 ..........................^-e:1:26 SyntaxError: invalid escape sequence:
INFO - -e:1:26 if ((!this.hasOwnProperty(\TypedObject)) || (!this.hasOwnProperty('TypedObject'))) qu
INFO - -e:1:26 ..........................^Exit code: 3
INFO - FAIL - TypedObject/bug1655906.js
WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/TypedObject/bug1655906.js | -e:1:26 SyntaxError: invalid escape sequence: (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.5 s]

Bob Clary [:bc] (inactive)

Comment 1

•

4 years ago

js/src/jit-test/tests/TypedObject/directives.txt has |jit-test| skip-if: !this.hasOwnProperty('TypedObject') while this test also contains // |jit-test| skip-if: !this.hasOwnProperty("TypedObject") which means we end up with a mixed quote case similar to Bug 1653301.

Since the directory contains the skip-if value for all tests, we can fix this by removing the skip-if from the actual test.

jan: Do you want to take care of this or should I?

Flags: needinfo?(jdemooij)

Regressed by: 1655906

BMO Automation

Updated

•

4 years ago

Has Regression Range: --- → yes

Keywords: regression

Comment hidden (Intermittent Failures Robot)

Jan de Mooij [:jandem]

Assignee

Comment 3

•

4 years ago

(In reply to Bob Clary [:bc] from comment #1)

jan: Do you want to take care of this or should I?

I'll fix. Ironic that I broke jit-tests again after reviewing your fix for the similar bug :)

It would be great to fix this footgun though.

Jan de Mooij [:jandem]

Assignee

Comment 4

•

4 years ago

Attached file Bug 1655982 - Remove redundant skip-if from TypedObject jit-test. r?bc! — Details

The directory has a directives.txt with the same skip-if. The mixed quotes also
broke jit-tests on Android.

Phabricator Automation

Updated

•

4 years ago

Assignee: nobody → jdemooij

Status: NEW → ASSIGNED

Jan de Mooij [:jandem]

Assignee

Updated

•

4 years ago

Flags: needinfo?(jdemooij)

Pulsebot

Comment 5

•

4 years ago

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9734ce2babea
Remove redundant skip-if from TypedObject jit-test. r=bc

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 6

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/9734ce2babea

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox81: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 81 Branch

BugBot [:suhaib / :marco/ :calixte]

Comment 7

•

4 years ago

Set release status flags based on info from the regressing bug 1655906

status-firefox79: --- → unaffected

status-firefox80: --- → unaffected

status-firefox-esr68: --- → unaffected

status-firefox-esr78: --- → unaffected

Comment hidden (Intermittent Failures Robot)

Bob Clary [:bc] (inactive)

Comment 9

•

4 years ago

(In reply to Jan de Mooij [:jandem] from comment #3)

It would be great to fix this footgun though.

fixed in bug 1655813

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

Intermittent tests/jit-test/jit-test/tests/TypedObject/bug1655906.js | -e:1:26 SyntaxError: invalid escape sequence: (code 3, args "") [0.4 s]

Categories

(Core :: JavaScript Engine, defect, P5)

Tracking

()

People

(Reporter: intermittent-bug-filer, Assigned: jandem)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Updated

Comment 2

Comment 3

Comment 4

Updated

Updated

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Attachment

General

Description

File Name

Content Type