1656101 - Delete unused BrowserProcessSubThread types (and x11_util.h)

Status: RESOLVED FIXED

(Core :: IPC, task)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I noticed that the only kind of BrowserProcessSubThread that's used is IO. The BACKGROUND_X11 type may have been briefly used for several months in 2009 but probably never shipped, and it's been unused since then (with a handful of comments still referring to it as if it existed, which were slowly deleted over the years); the others have been commented out since they were added. These can all be deleted.

BrowserProcessSubThread itself could probably be inlined out of existence, because there's not much it still does, but I'm not attempting that at this time.

I also noticed that x11_util.h, which was mostly deleted in bug 909028, has been unused since 2017 (bug 1426284); I'll delete that too.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1656101 - Delete some IPC dead code (BrowserProcessSubThread types and an unused header).

An actual use of the BACKGROUND_X11 thread may have briefly existed in
2009 but probably never shipped; it's been unused since then, and even
the comments mentioning it have been pruned (bug 909028, bug 624422).
The other thread types besides IO have been commented out ever since
they were first committed.

This patch also removes x11_util.h, which has been unused since 2017
(bug 1426284); earlier in history, it had one of those comments
mentioning the nonexistent X11 thread.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0edace9ffa4d
Delete some IPC dead code (BrowserProcessSubThread types and an unused header). r=mccr8

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0edace9ffa4d