Closed
Bug 909028
Opened 12 years ago
Closed 12 years ago
Remove dead chromium code
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
887.48 KB,
patch
|
ehsan.akhgari
:
review+
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
155 files changed, 31 insertions(+), 24563 deletions(-)
I think it catches all the code that isn't being compiled, and then some. I've got some smaller patches that build on this, but those can wait.
Attachment #795080 -
Flags: review?(ehsan)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 795080 [details] [diff] [review]
Patch v1
Review of attachment 795080 [details] [diff] [review]:
-----------------------------------------------------------------
This mostly looks good to me. It's not immediately clear why we can remove platform_util_mac.mm but I guess that's because the callers to all of the functions in that file have been removed?
Over to bent for a rubberstamp to mostly let him know about this!
Attachment #795080 -
Flags: review?(ehsan)
Attachment #795080 -
Flags: review?(bent.mozilla)
Attachment #795080 -
Flags: review+
Comment on attachment 795080 [details] [diff] [review]
Patch v1
If it builds rs=me ;)
Attachment #795080 -
Flags: review?(bent.mozilla) → review+
|
Assignee | |
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•