1656170 - Mozilla Nightly gets displayed instead of Mozilla Beta while using Remote debugging via USB

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect)

Description

[Andrei Jolțan [:Andi]]

Prerequisites

Enable "Remote debugging via USB" on Fenix

Steps to reproduce

Connect the device Via USB
Open Firefox desktop and load in a new tab about:debugging
Connect with the Android device

Expected behavior

Mozilla Beta should be displayed

Actual behavior

Mozilla Nightly is displayed

Device information

• Android device: all
• Fenix version: Fenix Beta 80.0.0-beta-1

Notes

Filled https://github.com/mozilla-mobile/fenix/issues/13108 on GitHub

image
image

Comment 1

[Julian Descottes [:jdescottes]]

The following check https://searchfox.org/mozilla-central/rev/cffd9b5302b6b6f51533d895a785b48ff418aec1/devtools/client/shared/remote-debugging/adb/adb-runtime.js#41 is no longer valid:

  get isFenix() {
    return this._packageName().includes("org.mozilla.fenix");
  }

Fenix's package name now start with org.mozilla.firefox. Fennec is not fully retired yes (at least in all regions), so I guess we could just check that the package name contains org.mozilla.firefox and main version is > 68

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1656170 - Update package name used to detect Fenix via ADB

The Fenix package name is now org.mozilla.firefox and not org.mozilla.fenix.
We need to update the logic in ADB to accommodate for this change.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cb90fa4f485
Update package name used to detect Fenix via ADB r=daisuke

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7cb90fa4f485

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 6

[Julian Descottes [:jdescottes]]

All versions are affected.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jdescottes, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Julian Descottes [:jdescottes]]

I don't think it's worth uplifting, this can ride the trains.