1659835 - about:debugging can't connect to Moto G (XT1031)

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P3)

Description

[Asif Youssuff]

What were you doing?

Please tell us what site you were on, and what steps led to the error you are reporting

1. Enable debugging on Android device and Fenix, plug it in.
2. Navigate to about:debugging
3. Enable USB devices

What happened?

After much effort (disabling debugging, revoking/allowing permissions), I see the device on the left side of the page, but the connect button never appears.

What should have happened?

I should be able to connect to the device.

Anything else we should know?

mozregression:

Bug 1656170 - Update package name used to detect Fenix via ADB r=daisuke

The Fenix package name is now org.mozilla.firefox and not org.mozilla.fenix.
We need to update the logic in ADB to accommodate for this change.

Differential Revision: https://phabricator.services.mozilla.com/D85396

2020-08-18T16:56:48.382000: DEBUG : Did not find a branch, checking all integration branches
2020-08-18T16:56:48.397000: INFO : The bisection is done.
2020-08-18T16:56:48.404000: INFO : Stopped

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1656170

Comment 2

[Julian Descottes [:jdescottes]]

Sorry for asking, but I can't reproduce so far.
Did you:

• enable USB debugging in Fenix Settings (not only in Android)
• have at least one tab open in Fenix

Can you also post your version of Fenix?

Comment 3

[Asif Youssuff]

USB debugging is enabled.

I am running Firefox Nightly 200818

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the info.

Do you see any relevant error in the Browser Console of Firefox desktop?
Can you add a screenshot of your about:debugging? I would like to check exactly how Fenix appears in the sidebar.

Comment 5

[Asif Youssuff]

Attachment: image.png

I don't see anything relevant in the browser console. :/

Comment 6

[Julian Descottes [:jdescottes]]

I still can't reproduce, but based on the initial bisect, I'm going to assume we fetch a firefox/fenix application with a version we can't parse at https://searchfox.org/mozilla-central/rev/d54210d490ef335b13fc1fcac817525120c8c46b/devtools/client/shared/remote-debugging/adb/adb-runtime.js#57

Will try to guard it a bit more.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1659835 - Set a default version name in DevTools adb-runtime

To my knowledge, versionName should always be defined via init, but adding a default value here to avoid potential issues.

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1659835 - Show org.mozilla.fenix.nightly as Firefox Nightly

Depends on D87846

While testing the latest Fenix Nightly I noticed that the package name was org.mozilla.fenix.nightly

Comment 9

[Julian Descottes [:jdescottes]]

That's not it either, an error there would make about:debugging completely blank.

I'm uploading a patch anyway, but I don't see anything in the regressing bug that can cause about:debugging to not find the browser.
If there was a JS error, it would fully break about:debugging. And if the logic was faulty, it would just treat Fenix as Fennec or vice versa, which would only impact the browser's name.

I would suspect something wrong on the device itself, but if you confirm that this worked before Bug 1656170, then it has to be something on the client side.

Comment 10

[Jens Stutte [:jstutte]]

Hi Julian, can you please assign a severity to this bug? Thank you!

Comment 11

[Julian Descottes [:jdescottes]]

Since we can't reproduce for now, setting S3/P3.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15eff799a29a
Set a default version name in DevTools adb-runtime r=daisuke
https://hg.mozilla.org/integration/autoland/rev/cfdb1b63441d
Show org.mozilla.fenix.nightly as Firefox Nightly r=daisuke

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/15eff799a29a
https://hg.mozilla.org/mozilla-central/rev/cfdb1b63441d