Closed Bug 1656189 Opened 5 years ago Closed 5 years ago

First click on fresh new window Top Sites link does nothing

Categories

(Firefox :: General, defect)

79 Branch
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: giacomofm, Unassigned)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

OS: Windows 10, on Firefox after update to version 79.0 while using about:newtab as homepage. Firefox Home Content: Web Search, Top Sites (2 rows), Snippets.
Open a fresh new window of Firefox, then click on one link in Top Sites.

Actual results:

The first click does not open the Top Sites' link, all other click works correctly.

Expected results:

Also the first click should open the Top Sites' link clicked.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → New Tab Page

Hi there, can you please let us know what link you are clicking on specifically? Thanks!

I think I can reproduce this, or a very similar issue.

I'm finding a potential regression range now.

Yeah the issue I found happens for all clicks on the page, not just 1 topsite, and happens only if you have the multi process debugger open by default.

So I don't have the same issue. I found a similar but fundamentally different issue.

The issue I found is filed here: https://bugzilla.mozilla.org/show_bug.cgi?id=1657194

(In reply to Gavin Suntop [:gvn] (they/them) from comment #2)

Hi there, can you please let us know what link you are clicking on specifically? Thanks!

Hi Gavin, I find out that while I'm clicking specifically on these links:

it behaves as described above, while when I click on others like www.amazon.it (2nd row 2nd from left) or https://www.youtube.com/ (2nd row 7th from left) it always opens the link even on the first click.

Could you provide us with the contents of about:support?

Flags: needinfo?(giacomofm)
Flags: needinfo?(sdowne)
Priority: -- → P5
Flags: needinfo?(giacomofm)

Hey Andrei and Rares.

As described in https://mana.mozilla.org/wiki/pages/viewpage.action?spaceKey=PI&title=PI+Request trying to get help investigation a bug.

This particular bug , I cannot seem to reproduce it and otherwise have nothing that comes to mind on what could be causing it.

Anything you can find that might help me narrow it down would be awesome.

Happy to answer any questions best I can!

Thanks

Flags: needinfo?(sdowne)
Flags: needinfo?(rares.bologa)
Flags: needinfo?(andrei.vaida)
Flags: needinfo?(rares.bologa)
Flags: needinfo?(cmuresan)
Flags: needinfo?(andrei.vaida)

I have the same bug in Firefox 79.0 (64-bit) on Windows 7.
Top sites link does not work correctly on 1st attempt in a fresh new window for the following links:

https://www.reddit.com
https://weather.com

Clicking again a 2nd time on these links will finally work normally.
Other top site links are working normally, even on the 1st attempt.

This bug is not limited to the Top Sites feature.
The same problem occurs in a fresh instance of Firefox if you access these particular items from the History menu.
1st time doesn't work, but 2nd try on same history item works normally.
Whichever items are failing on the 1st try in Top Sites are also failing on the 1st try in the History menu.

Also it seems like if you visit anything else successfully first after opening the instance of Firefox, and then try these problematic items afterward in Top Sites links, there is no issue at all with 1st click on the link. Apparently visiting another site (any site) successfully beforehand is enough to bypass whatever tickles this particular bug.

I'm not seeing a pattern with the links being reported, and I also cannot reproduce with them, in either topsites or history.

But I suspect if it's happening to all links for the original issue reporter too, getting this bug out of the newtab component and back into the general component would be a huge step in getting it the right attention it needs.

Component: New Tab Page → General

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Priority: P5 → --

I recently figured out that the same problem occurs even if you write (or paste) some URL directly in the address bar.
To give an example: open a fresh new window > paste or write "twitter.com" in the address bar > press enter - like the first click on a Top Sites' link the first time it does nothing, but if you then press enter again you go to the website. This behavior is strictly linked with some of the first links you are trying to open, every attempt after the first works correctly.

Since also Dave pointed out that this behavior is not strictly linked with Top Sites' clicks I suggest, if possible, to change the title of this issue in "First attempt to open some links in a fresh new window does nothing" if you agree.

Looked into this and leaving notes bellow.
81.0a1 (20200813092915) - default settings on Windows 10:

  • looking at something that might have a race condition in there;
  • noticed the same issue when trying to delete the tile from History(confirmation pop-up appearing on second click); this happened just 1 time then never again.

79.0 (20200720193547) Windows 10

  • nothing to report, appears to work fine from the 1st click(s).

Clearing ni of cmuresean as well.

Flags: needinfo?(cmuresan)

I tried watching in the Network Tool (Ctrl-Shift-E) to see what's happening when it fails on the first attempt to follow through the link.
And it looks like the GET request is "Blocked". At least that's what it says in the Transferred column.
Let me know if there are any other details I can gather from a user perspective, since I can reproduce the problem on demand.

Hm, the "Blocked" is interesting. Could this be related to Tracking Protection? Can you try turning Tracking Protection off (change it to Custom and uncheck Tracking Content and Cookies) in about:preferences? Or can you test in a new profile?

Flags: needinfo?(giacomofm)

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #18)

Hm, the "Blocked" is interesting. Could this be related to Tracking Protection? Can you try turning Tracking Protection off (change it to Custom and uncheck Tracking Content and Cookies) in about:preferences? Or can you test in a new profile?

Done, changed to Custom and unchecked then closed and reopened Firefox. Same problem, the first click does nothing. This time though when I reset the Tracking Protection to Standard every time I clicked (5 or 6 times) on the link "mail.live.com" it has been blocked like the fresh first click. So I closed and reopened and then it behaves as always.
I don't know if I got it across.

Flags: needinfo?(giacomofm)

Can you test by using mozregression to find when this started failing for you? Knowing when this was introduced will help us fix this.

https://mozilla.github.io/mozregression/

Flags: needinfo?(giacomofm)

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #20)

Can you test by using mozregression to find when this started failing for you? Knowing when this was introduced will help us fix this.

https://mozilla.github.io/mozregression/

I tried using mozregression but I was not able to reproduce the error with the nightly release. I then installed Firefox Nightly 81.0a1 (2020-08-20) (64-bit) but the error doesn't happen. I also tried to reset Firefox but after some restart this problem return behaving as described above.

The only thing I should point out is that during some tests with mozregression, a different error occurred when I clicked on a Top Site. I will attach the screenshot. I don't know if this could be related.

Flags: needinfo?(giacomofm)

I believe the bug (i.e. "Blocked" on first request to the affected history link) was introduced in 79.0
I am also able to make it happen in a new profile.
I manually reinstalled 78.0.2 and it does not have the problem.

Do you have any antivirus or firewall software installed?

Flags: needinfo?(giacomofm)

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #24)

Do you have any antivirus or firewall software installed?

Not on my desktop, it's plain Windows protected. In my laptop, where I can reproduce the error, I have an antivirus.

(In reply to Dave Glowny from comment #23)

I believe the bug (i.e. "Blocked" on first request to the affected history link) was introduced in 79.0
I am also able to make it happen in a new profile.
I manually reinstalled 78.0.2 and it does not have the problem.

I believe in this too, this error showed up after the 79 version update from what I can remember.

Flags: needinfo?(giacomofm)

Do you have any antivirus or firewall software installed?
Microsoft Security Essentials (Win7) is all that I have.
But I turned it off as an experiment to rule out antivirus as the cause, and the Firefox bug symptom still happens.

This is most likely a duplicate of bug 1656310

At least for me, it looks like the problem is fixed in Firefox 80.0

Same here, after the update to Firefox 80.0 I can't reproduce this error.

Hm, well that's at least good to know. Would be nice to know what caused it.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: