1656432 - Redesign `nsIEditActionListener::WillDeleteSelection()`

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It takes Selection and it's called by EditorBase::DeleteSelectionWithTransaction(). However, its user is only FinderHighlighter and it just wants the ranges. So, we should make it take array of ranges instead of Selection.

(Although, nsIEditActionListener has negative effect for editor performance, so, we should make FinderHighligher stop using it as soon as possible.)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656432 - part 1: Create `nsIEditActionListener::WillDeleteRanges()` r=m_kato!

Currently, nsIEditActionListener::WillDeleteSelection() notifies
FinderHighliter of deleting selection ranges. But it's referred only
the ranges, not selection object itself and editor shouldn't modify
Selection as far as possible for reducing the runtime cost.

Therefore, it should be replaced with this new API. Then,
EditorBase::WillDeleteSelectionWithTransaction() can be rewritten as
EditorBase::WillDeleteRangesWithTransaction() later.

Depends on D85578

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656432 - part 2: Make `FinderHighlighter` use `nsIEditActionListener::WillDeleteRanges()` instead of `nsIEditActionListener::WillDeleteSelection()` r=Gijs!

For making editor performance better and editor code simpler, I want to
stop modifying Selection as far as possible. Therefore, I'd like to
get rid of nsIEditActionListener. Instead, there is new API,
nsIEditActionListener::WillDeleteRanges(). This patch rewrites
FinderHighlighter#WillDeleteSelection() to
FinderHighlighter#WillDeleteRanges().

Depends on D85681

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656432 - part 3: Get rid of `nsIEditActionListener::WillDeleteSelection()` r=m_kato!

Depends on D85682

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/383394e45625
part 1: Create `nsIEditActionListener::WillDeleteRanges()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ae648f1dd7c9
part 2: Make `FinderHighlighter` use `nsIEditActionListener::WillDeleteRanges()` instead of `nsIEditActionListener::WillDeleteSelection()` r=Gijs
https://hg.mozilla.org/integration/autoland/rev/86048138135b
part 3: Get rid of `nsIEditActionListener::WillDeleteSelection()` r=m_kato

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/383394e45625
https://hg.mozilla.org/mozilla-central/rev/ae648f1dd7c9
https://hg.mozilla.org/mozilla-central/rev/86048138135b