1656531 - Ctrl+F in Options tab brings up duplicated find bar - should focus options search field instead

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect, P3)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: duplicated find bar in Options

Seen on 81.0a1 (2020-07-30) (64-bit)

STR

1. tools > options
2. press Ctrl+F

Actual

• duplicated find bar at bottom
• showing find bar makes little sense for this tab, because options search does the job better

Expected

• don't show duplicated findbar
• Ctrl+F to focus options search field instead

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=e8be57e6a6c378331814db495fa864b018c0554c&tochange=67022d52f8ed7b8e270f29f2b774ce5ec236f753
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3e0cf2f77f07b258e8911ab5fd71a378c46fa1ec&tochange=54ed5eac2abca2519704c74bc5c421b846031504

Suspect:
4a4cb34568406190a3473973622d20e2e2b63607 Geoff Lankow — Bug 1527770 - Convert Thunderbird preferences to use preferencesBindings.js; r=aceman
333fa90d259dc5d99a081b6bd38e9d6fd6157b3d Geoff Lankow — Bug 1527770 - Copy preferences.xml into suite to preserve history; rs=me

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1656531_focus-search-input-on-ctrl-f-0.patch

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9169460 [details] [diff] [review]
Bug-1656531_focus-search-input-on-ctrl-f-0.patch

Review of attachment 9169460 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/preferences/preferences.js
@@ +144,5 @@
>    document.documentElement.addEventListener("keydown", event => {
>      if (event.keyCode == KeyEvent.DOM_VK_TAB) {
>        categories.setAttribute("keyboard-navigation", "true");
> +    } else if (
> +      (event.altKey || event.metaKey) &&

The shortcut (on non-mac) is Ctrl+F, so the patch doesn't work using altKey.

Can we also use event.code == "F" instead. keyCode is deprected

Comment 4

[Thomas D. (:thomas8)]

(In reply to Magnus Melin [:mkmelin] from comment #3)

Comment on attachment 9169460 [details] [diff] [review] ⧉[details] [diff] [review]
Bug-1656531_focus-search-input-on-ctrl-f-0.patch

Review of attachment 9169460 [details] [diff] [review] ⧉[details] [diff] [review]:
::: mail/components/preferences/preferences.js
@@ +144,5 @@

document.documentElement.addEventListener("keydown", event => {
if (event.keyCode == KeyEvent.DOM_VK_TAB) {
Can we also use event.code == "F" instead. keyCode is deprected

I think the best current syntax is event.key == "Tab" / event.key == "f" [sic, lowercase!], which we have used for all new listeners in Thunderbird. event.code would be "KeyF", and it's for physical keys on keyboard, not what we want.
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

To determine what character corresponds with the key event, use the KeyboardEvent.key property instead.

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1656531_focus-search-input-on-ctrl-f-1.patch

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9169616 [details] [diff] [review]
Bug-1656531_focus-search-input-on-ctrl-f-1.patch

Review of attachment 9169616 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0cf6798c85fc
Focus options search field with Ctrl+F in Options tab (instead of bringing up duplicated find bar). r=mkmelin

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9169616 [details] [diff] [review]
Bug-1656531_focus-search-input-on-ctrl-f-1.patch

[Approval Request Comment]
Safe fix for minor issue that would be more visible now that we have the search field in the preferences.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9169616 [details] [diff] [review]
Bug-1656531_focus-search-input-on-ctrl-f-1.patch

[Triage Comment]
Approved for beta
Approved for esr78

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 80.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/d8f9ea58368d

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/212b7cfb0b4d

Comment 12

[WaltS48 [:walts48]]

No duplicated find bar appeared in my testing of TB 80.0b4 on Ubuntu 18.04.4 LTS.

The Preferences tab opened with a blinking bar in the Search field ready to start typing without needing to use any key combinations.

Comment 13

[Thomas D. (:thomas8)]

(In reply to WaltS48 [:walts48] from comment #12)

No duplicated find bar appeared in my testing of TB 80.0b4 on Ubuntu 18.04.4 LTS.

Try this:

• switch to 3-pane (ensure focus on folder list)
• switch back to Options by clicking on Options tab top
• press Ctrl+F
• or instead, try cursor-up/down and monitor the 3-pane tab top... (see screencast attachment 9177466 [details] for the account settings equivalent).

Welcome to the world of "background tab focus" in Thunderbird. It's unfortunate that our tabs are technically not as independent as they might appear to be...