1656587 - Retrieve Default Printer Name Using CUPS on macOS

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P1)

Description

[Erik Nordin [:nordzilla]]

Now that we can retrieve printers through CUPS, we can retrieve the default printer name this way as well.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1656587 - Retrieve Default Printer Name Using CUPS r=jwatt,alaskanemily

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/451369452f15
Retrieve Default Printer Name Using CUPS r=AlaskanEmily

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for linux Hazard bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=451369452f15b5f6cbefc90e75c02b95bc76109e&searchStr=Linux%2Cx64%2Cdebug%2Chazard-linux64-haz%2Fdebug%2CH&selectedTaskRun=CtmbEN0dRwGC7S6lym-Qnw.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=312227247&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/9950354e1a3876814e1ffbe0fbe7826a5b0ba7c6

Comment 5

[Erik Nordin [:nordzilla]]

Apparently there are some C++ compilers that have an issue with, for example:

void foo(int) {}

class bar {
  decltype(foo)* foo;
};

Other compilers (such as the ones I tested with) do not.

So to avoid this inconsistency in com, we're going to have to be explicit about the global scope.
To fix the example, this would mean:

  decltype(::foo)* foo;

To fix this code, we'll have to change the declaration macro from

#define CUPS_SHIM_FUNC_DECL(X) decltype(X)* X;

to

#define CUPS_SHIM_FUNC_DECL(X) decltype(::X)* X;

so that we are explicit about decltypeing from the globally scoped function that exists in cups.h

I believe that should fix the issue.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abd5a8175a5c
Retrieve Default Printer Name Using CUPS r=AlaskanEmily

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/abd5a8175a5c