Closed Bug 1657518 Opened 1 year ago Closed 1 year ago

Clean up GetName() functionality for CUPS printers

Categories

(Core :: Printing: Setup, enhancement, P2)

Product:
Core
Component:
Printing: Setup
Version:
Firefox 81
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: nordzilla, Assigned: nordzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: [print2020_v81] )

Attachments

(1 file)

Bug 1657518 - Clean up nsCUPSPrinter GetName() Functionality r=jwatt,alaskanemily,emilio
47 bytes, text/x-phabricator-request
Details | Review

The nsCUPSPrinter's GetName() function could be improved to return the printer's display name, if available, by checking for it via the cupsGetOption() method.

  • Add cupsGetOption function support to CUPSShim
  • Remove mDisplayName member from nsPrinterCUPS
  • Modify GetName() function to retun display name if available.
Depends on: 1656587
Blocks: 1651112
Attachment #9168328 - Attachment description: Bug 1657518 - Clean up nsCUPSPrinter GetName() Functionality r=jwatt,alaskanemily → Bug 1657518 - Clean up nsCUPSPrinter GetName() Functionality r=jwatt,alaskanemily,emilio
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a8210e1c9f4
Clean up nsCUPSPrinter GetName() Functionality r=emilio

https://hg.mozilla.org/mozilla-central/rev/7a8210e1c9f4

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox81: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.