1656797 - Link about LEGACY extensions in Add-ons Manager is broken

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Peter Madsen]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

In the add-ons Manager many Extensions and Themes are marked LEGACY - I clicked the LEGACY link.

Actual results:

I am taken to https://www.seamonkey-project.org/doc/webextensions which says:
"Page Not Found
We're sorry, but we can't find what you're looking for." ... etc.

Expected results:

I expected to get information about Legacy extensions, and what it entails.

Comment 1

[Frank-Rainer Grahl (:frg)]

Screenshot please. Which theme? Which version and where did you get it? The legacy marking is suppressed in the distributed themes.

Comment 2

[Frank-Rainer Grahl (:frg)]

Bug 1365170 disabled it for all themes.

Comment 3

[Peter Madsen]

Attachment: legacy-appearance.png

Comment 4

[Peter Madsen]

Attachment: legacy-extensions.png

Comment 5

[Peter Madsen]

(In reply to Frank-Rainer Grahl (:frg) from comment #1)

Screenshot please. Which theme? Which version and where did you get it? The legacy marking is suppressed in the distributed themes.

All themes but SeaMonkey Default and SeaMonkey Modern ( and themes that are marked as extensions.legacy.exceptions )
All extensions except for Lightning, Chatzilla and DOM Inspector.

It is not whether or not the add-ons are marked as LEGACY or not - it is that clicking on the word LEGACY takes you to a "Page Not Fond" page, that I am describing as an error - as such not a bug in SeaMonkey, but in https://www.seamonkey-project.org

See screenshots

Comment 6

[Frank-Rainer Grahl (:frg)]

Yes but it seems the style change from Bug 1365170 gets overwritten or is not used by the pinball third party theme. If you use classic or modern legacy is not displayed and clicking is not possible so no error is shown.

If pinball overrides it just needs to use

.legacy-warning {
display: none;
}

and the problem will disappear.

Comment 7

[Peter Madsen]

Attachment: legacywarning_defaulttheme.png

Comment 8

[Peter Madsen]

(In reply to Frank-Rainer Grahl (:frg) from comment #6)

Yes but it seems the style change from Bug 1365170 gets overwritten or is not used by the pinball third party theme. If you use classic or modern legacy is not displayed and clicking is not possible so no error is shown.

If pinball overrides it just needs to use

.legacy-warning {
display: none;
}

and the problem will disappear.

Well, see my new screenshot - I also get the legacy warning with the SeaMonkey Default Theme in Seamonkey 2.53.3 - but I will check out the css snip

Comment 9

[Peter Madsen]

Attachment: legacywarnin_morderntheme.png

Comment 10

[Peter Madsen]

Legacy warning is also shown in the shipped SeaMonkey Modern Teme - see screenshot.

The screenshot also shows a bug in the Modern themes - lines are not wrapped in description of the extensions, leading to a window in full screen width.

the css code:
.legacy-warning {
display: none;
}
works fine for Pinball - thanks for the tip.

Comment 11

[Peter Madsen]

Attachment: nolegacywarning_pinballtheme.png

Comment 12

[Peter Madsen]

But I would still want to know more details about legacy extensions, hence I would like the page https://www.seamonkey-project.org/doc/webextensions to give that information.

Comment 13

[Peter Madsen]

Comment on attachment 9168212 [details]
nolegacywarning_pinballtheme.png

Pinball after addding 

.legacy-warning {
display: none;
} 

to [e-mail]\mozapps\extensions\extensions.css

Comment 14

[Frank-Rainer Grahl (:frg)]

Attachment: Modern Theme with long line

Hmm can't reproduce. Never saw the legacy link after killing it in the mentioned bug. Can you probably test in a new profile and then install pinball there to see if it changes.

As a last resort we can kill the legacy in our Mozilla Gecko release branch but probably not for 2.53.4

Comment 15

[Peter Madsen]

Attachment: addonsmanger_tabbed-and_stand-alone.png

"Legacy" shown in stand-alon Add-ons Manger but not in tabbed Add-ons Manager

Comment 16

[Peter Madsen]

(In reply to Frank-Rainer Grahl (:frg) from comment #14)

Created attachment 9168241 [details]
Modern Theme with long line

Hmm can't reproduce. Never saw the legacy link after killing it in the mentioned bug. Can you probably test in a new profile and then install pinball there to see if it changes.

As a last resort we can kill the legacy in our Mozilla Gecko release branch but probably not for 2.53.4

I tried with a new profile, and that gave me the clue: "Legacy" is shown in stand-alone Add-ons Manger but NOT in tabbed Add-ons Manager.

See screenshot

Comment 17

[Ian Neal]

Attachment: 1656797-remove-legacy-25310.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Useless legacy indicator / link
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 18

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9242940 [details] [diff] [review]
1656797-remove-legacy-25310.patch

LGTM

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/510c9f5221da
Link about LEGACY extensions in Add-ons Manager is broken. r=frg

Comment 20

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/51c0ad1d267ae5a9f4433fcf6b33461b1aa4190c
Link about LEGACY extensions in Add-ons Manager is broken. r=frg a=frg