1656813 - Fix various swgl test failures

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Initial work to get most tests running and passing.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656813 - Clang format gl.cc. r?lsalzman

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656813 - Add SWGL support for UNSIGNED_INT_8_8_8_8_REV. r?lsalzman

Depends on D85711

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656813 - Make swgl a dependency of gkrust so that we have correct dependencies for sccache. r?glandium

See https://github.com/rust-lang/rust/issues/58393

Depends on D85712

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656813 - Remove document layer from ZBufferIdGenerator allocation. r?gw

This was added for document splitting, which has since been removed from Gecko.

Depends on D85713

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656813 - Annotate fuzzy reftest differences. r?lsalzman

These are all subtle differences that aren't visible, many are actually less fuzzy than with normal WR.

Depends on D85714

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656813 - Set correct blend mode for non-premultiplied alpha. r?gw

I believe this is correct for blending a non-premuliplied source into a premultiplied destination. Only the source color part should be different to normal blending, since it needs to be multiplied by the source alpha channel.

Depends on D85715

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656813 - Mark failing test. r?lsalzman

Depends on D85716

Comment 8

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656813 - Implement non-premultiplied blending in SWGL. r?lsalzman

Depends on D85717

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12c0e9554a5f
Clang format gl.cc. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/37e5e5e6593a
Add SWGL support for UNSIGNED_INT_8_8_8_8_REV. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/060254b3ad73
Make swgl a dependency of gkrust so that we have correct dependencies for sccache. r=glandium
https://hg.mozilla.org/integration/autoland/rev/4d6a3bf61345
Remove document layer from ZBufferIdGenerator allocation. r=gw
https://hg.mozilla.org/integration/autoland/rev/d1c313ebe358
Annotate fuzzy reftest differences. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/efed1b35fe47
Set correct blend mode for non-premultiplied alpha. r=gw
https://hg.mozilla.org/integration/autoland/rev/1b3842f2ca27
Mark failing test. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/92e0209dc7f1
Implement non-premultiplied blending in SWGL. r=lsalzman

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for OSX reftest failures on bipbop_300_215kbps.mp4.lastframe.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=92e0209dc7f1ad1f15c65cd265e18bc26889f007&searchStr=reftest&failure_classification_id=2&selectedTaskRun=BkXMHHM1SUe0_24OwVkZxQ.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=312074794&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/019363ddffdfe7762cbe98b5d1ffbe5777e0c41f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d32a631ca7b8
Clang format gl.cc. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/d2df03f2e7e6
Add SWGL support for UNSIGNED_INT_8_8_8_8_REV. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/513d01d2b20c
Make swgl a dependency of gkrust so that we have correct dependencies for sccache. r=glandium
https://hg.mozilla.org/integration/autoland/rev/bf725e1af72f
Remove document layer from ZBufferIdGenerator allocation. r=gw
https://hg.mozilla.org/integration/autoland/rev/8297d4038a64
Annotate fuzzy reftest differences. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/da064f2b33cd
Set correct blend mode for non-premultiplied alpha. r=gw
https://hg.mozilla.org/integration/autoland/rev/f737225966f8
Mark failing test. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/4129e0bd7867
Implement non-premultiplied blending in SWGL. r=lsalzman

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d32a631ca7b8
https://hg.mozilla.org/mozilla-central/rev/d2df03f2e7e6
https://hg.mozilla.org/mozilla-central/rev/513d01d2b20c
https://hg.mozilla.org/mozilla-central/rev/bf725e1af72f
https://hg.mozilla.org/mozilla-central/rev/8297d4038a64
https://hg.mozilla.org/mozilla-central/rev/da064f2b33cd
https://hg.mozilla.org/mozilla-central/rev/f737225966f8
https://hg.mozilla.org/mozilla-central/rev/4129e0bd7867