Closed Bug 1656813 Opened 4 months ago Closed 4 months ago

Fix various swgl test failures

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(8 files)

Initial work to get most tests running and passing.

This was added for document splitting, which has since been removed from Gecko.

Depends on D85713

These are all subtle differences that aren't visible, many are actually less fuzzy than with normal WR.

Depends on D85714

I believe this is correct for blending a non-premuliplied source into a premultiplied destination. Only the source color part should be different to normal blending, since it needs to be multiplied by the source alpha channel.

Depends on D85715

Depends on D85716

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12c0e9554a5f
Clang format gl.cc. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/37e5e5e6593a
Add SWGL support for UNSIGNED_INT_8_8_8_8_REV. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/060254b3ad73
Make swgl a dependency of gkrust so that we have correct dependencies for sccache. r=glandium
https://hg.mozilla.org/integration/autoland/rev/4d6a3bf61345
Remove document layer from ZBufferIdGenerator allocation. r=gw
https://hg.mozilla.org/integration/autoland/rev/d1c313ebe358
Annotate fuzzy reftest differences. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/efed1b35fe47
Set correct blend mode for non-premultiplied alpha. r=gw
https://hg.mozilla.org/integration/autoland/rev/1b3842f2ca27
Mark failing test. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/92e0209dc7f1
Implement non-premultiplied blending in SWGL. r=lsalzman
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d32a631ca7b8
Clang format gl.cc. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/d2df03f2e7e6
Add SWGL support for UNSIGNED_INT_8_8_8_8_REV. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/513d01d2b20c
Make swgl a dependency of gkrust so that we have correct dependencies for sccache. r=glandium
https://hg.mozilla.org/integration/autoland/rev/bf725e1af72f
Remove document layer from ZBufferIdGenerator allocation. r=gw
https://hg.mozilla.org/integration/autoland/rev/8297d4038a64
Annotate fuzzy reftest differences. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/da064f2b33cd
Set correct blend mode for non-premultiplied alpha. r=gw
https://hg.mozilla.org/integration/autoland/rev/f737225966f8
Mark failing test. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/4129e0bd7867
Implement non-premultiplied blending in SWGL. r=lsalzman
Flags: needinfo?(matt.woodrow)
Regressions: 1657545
You need to log in before you can comment on or make changes to this bug.