Fix various swgl test failures
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(8 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Initial work to get most tests running and passing.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D85711
Assignee | ||
Comment 3•4 years ago
|
||
See https://github.com/rust-lang/rust/issues/58393
Depends on D85712
Assignee | ||
Comment 4•4 years ago
|
||
This was added for document splitting, which has since been removed from Gecko.
Depends on D85713
Assignee | ||
Comment 5•4 years ago
|
||
These are all subtle differences that aren't visible, many are actually less fuzzy than with normal WR.
Depends on D85714
Assignee | ||
Comment 6•4 years ago
|
||
I believe this is correct for blending a non-premuliplied source into a premultiplied destination. Only the source color part should be different to normal blending, since it needs to be multiplied by the source alpha channel.
Depends on D85715
Assignee | ||
Comment 7•4 years ago
|
||
Depends on D85716
Assignee | ||
Comment 8•4 years ago
|
||
Depends on D85717
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/12c0e9554a5f Clang format gl.cc. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/37e5e5e6593a Add SWGL support for UNSIGNED_INT_8_8_8_8_REV. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/060254b3ad73 Make swgl a dependency of gkrust so that we have correct dependencies for sccache. r=glandium https://hg.mozilla.org/integration/autoland/rev/4d6a3bf61345 Remove document layer from ZBufferIdGenerator allocation. r=gw https://hg.mozilla.org/integration/autoland/rev/d1c313ebe358 Annotate fuzzy reftest differences. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/efed1b35fe47 Set correct blend mode for non-premultiplied alpha. r=gw https://hg.mozilla.org/integration/autoland/rev/1b3842f2ca27 Mark failing test. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/92e0209dc7f1 Implement non-premultiplied blending in SWGL. r=lsalzman
Comment 10•4 years ago
|
||
Backed out for OSX reftest failures on bipbop_300_215kbps.mp4.lastframe.html
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=312074794&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/019363ddffdfe7762cbe98b5d1ffbe5777e0c41f
Comment 11•4 years ago
|
||
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d32a631ca7b8 Clang format gl.cc. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/d2df03f2e7e6 Add SWGL support for UNSIGNED_INT_8_8_8_8_REV. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/513d01d2b20c Make swgl a dependency of gkrust so that we have correct dependencies for sccache. r=glandium https://hg.mozilla.org/integration/autoland/rev/bf725e1af72f Remove document layer from ZBufferIdGenerator allocation. r=gw https://hg.mozilla.org/integration/autoland/rev/8297d4038a64 Annotate fuzzy reftest differences. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/da064f2b33cd Set correct blend mode for non-premultiplied alpha. r=gw https://hg.mozilla.org/integration/autoland/rev/f737225966f8 Mark failing test. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/4129e0bd7867 Implement non-premultiplied blending in SWGL. r=lsalzman
Assignee | ||
Updated•4 years ago
|
Comment 12•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d32a631ca7b8
https://hg.mozilla.org/mozilla-central/rev/d2df03f2e7e6
https://hg.mozilla.org/mozilla-central/rev/513d01d2b20c
https://hg.mozilla.org/mozilla-central/rev/bf725e1af72f
https://hg.mozilla.org/mozilla-central/rev/8297d4038a64
https://hg.mozilla.org/mozilla-central/rev/da064f2b33cd
https://hg.mozilla.org/mozilla-central/rev/f737225966f8
https://hg.mozilla.org/mozilla-central/rev/4129e0bd7867
Description
•