1656818 - swgl readback is upside down

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Matt Woodrow (:mattwoodrow)]

SWGL readback is currently upside down, and shows that way for reftest images.

This doesn't really cause any issues for reftests (since both test and ref are the same orientation), but likely matters for other usage of readback.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656818 - Move decision to flip WebRender readback closer to the source, and make it correct for SWGL. r?lsalzman

Depends on D86891

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1656818 - Remove unnecessary copy from CanvasRenderingContext2D::DrawWindow. r?lsalzman

Depends on D86892

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92252cfd26de
Move decision to flip WebRender readback closer to the source, and make it correct for SWGL. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/9c8e4ec4e47c
Remove unnecessary copy from CanvasRenderingContext2D::DrawWindow. r=lsalzman

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for bustage on RendererOGL.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/f9394899c91cfedfa20529d37adecfb643f0ef9e

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=LDzo93YsRmiI6DfAtyBfOA.0&revision=9c8e4ec4e47c7c3320e26cf9a807140ab38ce88c&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312959660&repo=autoland&lineNumber=15302

[task 2020-08-13T21:19:35.852Z] 21:19:35 INFO - In file included from Unified_cpp_webrender_bindings1.cpp:2:
[task 2020-08-13T21:19:35.852Z] 21:19:35 ERROR - /builds/worker/checkouts/gecko/gfx/webrender_bindings/RendererOGL.cpp:178:14: error: use of undeclared identifier 'gfxVars'; did you mean 'gfx::gfxVars'?
[task 2020-08-13T21:19:35.852Z] 21:19:35 INFO - !gfxVars::UseSoftwareWebRender() && !mCompositor->UseANGLE();
[task 2020-08-13T21:19:35.852Z] 21:19:35 INFO - ^~~~~~~
[task 2020-08-13T21:19:35.852Z] 21:19:35 INFO - gfx::gfxVars
[task 2020-08-13T21:19:35.854Z] 21:19:35 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/gfx/gfxVars.h:86:7: note: 'gfx::gfxVars' declared here
[task 2020-08-13T21:19:35.854Z] 21:19:35 INFO - class gfxVars final {
[task 2020-08-13T21:19:35.854Z] 21:19:35 INFO - ^
[task 2020-08-13T21:19:35.854Z] 21:19:35 INFO - 1 error generated.
[task 2020-08-13T21:19:35.856Z] 21:19:35 INFO - /builds/worker/checkouts/gecko/config/rules.mk:723: recipe for target 'Unified_cpp_webrender_bindings1.o' failed
[task 2020-08-13T21:19:35.857Z] 21:19:35 ERROR - make[4]: *** [Unified_cpp_webrender_bindings1.o] Error 1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64b98572f2e0
Move decision to flip WebRender readback closer to the source, and make it correct for SWGL. r=lsalzman,geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/e04237d752ed
Remove unnecessary copy from CanvasRenderingContext2D::DrawWindow. r=lsalzman

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/64b98572f2e0
https://hg.mozilla.org/mozilla-central/rev/e04237d752ed