1670139 - sw-wr: Firefox Profiler's screenshots of sw-wr content are upside down

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Steps to reproduce

1. Enable gfx.webrender.software = true.
2. Enable the Firefox Profiler: https://profiler.firefox.com/
3. Capture a profile (including screenshots) while browsing some web pages.
4. View the profile and hover over the "Screenshots" row.

(In the profiles below, I was cycling through the images on my tweet here to test sw-wr perf bug 1623093: https://twitter.com/cpeterso/status/1313712283978096640/photo/1

Expected result

The profile's screenshots are right-side up with sw-wr disabled (default):

https://share.firefox.dev/2GHwgYb

Actual results

The profile's screenshots are upside down with sw-wr enabled:

https://share.firefox.dev/3dj8nCc

This problem sounds similar to swgl readback bug 1656818.

Comment 1

[Darkspirit]

Gnome X11, Mesa/Nouveau, Debian Testing
mozregression --good 2020-05-01 --bad 2020-10-12 --pref gfx.webrender.all:true gfx.webrender.software:true -a https://profiler.firefox.com

14:36.63 INFO: Last good revision: 04ed910d0a2fa35e25c9d88a66cdead6777eacd6
14:36.63 INFO: First bad revision: e5cfc0f5d9c52a3ee66ff4a21deeea7e8bf606bc
14:36.63 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=04ed910d0a2fa35e25c9d88a66cdead6777eacd6&tochange=e5cfc0f5d9c52a3ee66ff4a21deeea7e8bf606bc

bug 1646835 introduced full software compositing and support for Profiler screenshots - since then they are upside down.
Screenshots were solid black or grey before bug 1646835.

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1670139 - surface origin for RenderCompositorSWGL is top left. r?mattwoodrow

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93c312520166
surface origin for RenderCompositorSWGL is top left. r=mattwoodrow

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/93c312520166