Closed Bug 1656971 Opened 2 years ago Closed 2 years ago

upgrade from 68 to 78 forgets name of address book used in message filter to check sender's existence in it (changed to Personal Address Book)

Categories

(Thunderbird :: Filters, defect, P1)

Tracking

(thunderbird_esr68 unaffected, thunderbird_esr78+ fixed, thunderbird80 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
thunderbird_esr68 --- unaffected
thunderbird_esr78 + fixed
thunderbird80 --- fixed

People

(Reporter: aryx, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

(Keywords: dataloss, regression)

Attachments

(1 file)

Thunderbird 78.1.0 on Windows 8.1

The upgrade from 68 to 78 forgets the name of the address book used in a message filter to check the sender's existence in it (changed to Personal Address Book).

Steps to reproduce:

  1. With Thunderbird 68, create a new profile.
  2. Create an email account.
  3. Open the address book.
  4. Open menu File > New > Address Book.
  5. Create an address book with the name "Test".
  6. Add a contact to it: "Turtle Testing" turtle@testing.example.org
  7. In menu "Tools", open "Message Filters".
  8. Add a filter which checks if "From" is in the address book "Test". As action, e.g. choose to move it to the Trash folder.
  9. Save the filter and exit Thunderbird.
  10. Launch the profile with Thunderbird 78.
  11. Check the message filter.

Actual result:
Filter checks against "Personal Address Book" now.

Expected result:
Filter still checks address book "Test".

Blocks: tb78found

Yeah, I can see why that would happen. We changed the address books' URIs, and the filters reference URIs.

Priority: -- → P1
Assignee: nobody → geoff
Status: NEW → ASSIGNED

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/67f3ca8a1259
Migrate address book URIs in message filters. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Attachment #9169379 - Flags: approval-comm-beta?

Comment on attachment 9169379 [details]
Bug 1656971 - Migrate address book URIs in message filters. r?mkmelin

[Triage Comment]
Approved for beta

Attachment #9169379 - Flags: approval-comm-beta? → approval-comm-beta+

Should be a blocker for first automatic update ESR 78 version.

It is a definite candidate for 78, now that it is fixed.

Walt, can you confirm an update fixes a filter referencing an address book?

Severity: -- → S2
Flags: needinfo?(wls220spring)
Flags: needinfo?(geoff)
Keywords: dataloss
Flags: needinfo?(geoff)
Attachment #9169379 - Flags: approval-comm-esr78?

Comment on attachment 9169379 [details]
Bug 1656971 - Migrate address book URIs in message filters. r?mkmelin

[Triage Comment]
Approved for esr78

Attachment #9169379 - Flags: approval-comm-esr78? → approval-comm-esr78+

(In reply to Wayne Mery (:wsmwk) from comment #7)

It is a definite candidate for 78, now that it is fixed.

Walt, can you confirm an update fixes a filter referencing an address book?

Just tested with the reporters STR using:
Name Thunderbird
Version 78.2.0
Build ID 20200814165000
on Ubuntu 18.04.5 LTS and the filter still shows "Test".

Flags: needinfo?(wls220spring)
You need to log in before you can comment on or make changes to this bug.