1656971 - upgrade from 68 to 78 forgets name of address book used in message filter to check sender's existence in it (changed to Personal Address Book)

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird 78.1.0 on Windows 8.1

The upgrade from 68 to 78 forgets the name of the address book used in a message filter to check the sender's existence in it (changed to Personal Address Book).

Steps to reproduce:

1. With Thunderbird 68, create a new profile.
2. Create an email account.
3. Open the address book.
4. Open menu File > New > Address Book.
5. Create an address book with the name "Test".
6. Add a contact to it: "Turtle Testing" [e-mail]
7. In menu "Tools", open "Message Filters".
8. Add a filter which checks if "From" is in the address book "Test". As action, e.g. choose to move it to the Trash folder.
9. Save the filter and exit Thunderbird.
10. Launch the profile with Thunderbird 78.
11. Check the message filter.

Actual result:
Filter checks against "Personal Address Book" now.

Expected result:
Filter still checks address book "Test".

Comment 1

[Geoff Lankow (:darktrojan) [away until April 11]]

Yeah, I can see why that would happen. We changed the address books' URIs, and the filters reference URIs.

Comment 2

[Geoff Lankow (:darktrojan) [away until April 11]]

Attachment: Bug 1656971 - Migrate address book URIs in message filters. r?mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/67f3ca8a1259
Migrate address book URIs in message filters. r=mkmelin

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9169379 [details]
Bug 1656971 - Migrate address book URIs in message filters. r?mkmelin

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 80.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/16db5657287f

Comment 6

[Alex Ihrig [:Thunderbird_Mail_DE]]

Should be a blocker for first automatic update ESR 78 version.

Comment 7

[Wayne Mery (:wsmwk)]

It is a definite candidate for 78, now that it is fixed.

Walt, can you confirm an update fixes a filter referencing an address book?

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9169379 [details]
Bug 1656971 - Migrate address book URIs in message filters. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/776fb4444c53

Comment 10

[WaltS48 [:walts48]]

(In reply to Wayne Mery (:wsmwk) from comment #7)

It is a definite candidate for 78, now that it is fixed.

Walt, can you confirm an update fixes a filter referencing an address book?

Just tested with the reporters STR using:
Name Thunderbird
Version 78.2.0
Build ID 20200814165000
on Ubuntu 18.04.5 LTS and the filter still shows "Test".