Closed Bug 1657060 Opened 6 months ago Closed 6 months ago

Intermittent TEST-UNEXPECTED-TIMEOUT | toolkit/mozapps/update/tests/unit_aus_update/languagePackUpdates.js | Test timed out

Categories

(Thunderbird :: Upstream Synchronization, defect, P5)

defect

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
81 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: intermittent-bug-filer, Assigned: darktrojan)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Dave, can you offer any insight as to why this test would fail on Thunderbird, or if we should even be running it?

Flags: needinfo?(dtownsend)

I think you should be running it. It looks like for some reason the test is going on to stage the update rather than stopping after downloading and so it sends out the wrong observer notification. It looks like I may have mistakenly thought that staging is disabled by default in xpcshell tests but I see some of the tests explicitly disabling it. That might be the fix. But then I'm not sure why Firefox is behaving differently here.

Flags: needinfo?(dtownsend)
Assignee: nobody → geoff
Status: NEW → ASSIGNED

You're right, and that's set to true in the default preferences, which for some reason get read during Thunderbird XPCShell tests but not in Firefox ones.

Why? That's good old bug 1168178... so the app.update.staging.enabled true pref in firefox.js is not used.

(In reply to Magnus Melin [:mkmelin] from comment #7)

Why? That's good old bug 1168178... so the app.update.staging.enabled true pref in firefox.js is not used.

Sure, that's what I expected. What I don't understand is why are the Thunderbird prefs being used in this case?

Because Thunderbird does run xpcshell tests with normal app profile, so the app.update.staging.enabled true in all-thunderbird.js gets picked up.
We'd miss a lot of needed adjustments if we didn't use that, but it's of course unfortunate - for us, and I think in general too - that Firefox doesn't as well.

Attachment #9168349 - Attachment description: Bug 1657060 - Disable app update staging in a test. r?Mossop → Bug 1657060 - Disable app update staging in AUS tests. r?Mossop
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/integration/autoland/rev/e9009816330a
Disable app update staging in AUS tests. r=mossop
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.