1657060 - Intermittent TEST-UNEXPECTED-TIMEOUT | toolkit/mozapps/update/tests/unit_aus_update/languagePackUpdates.js | Test timed out

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=311961906&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fPKKCWVrQGaXTMqVvSPGPQ/runs/0/artifacts/public/logs/live_backing.log

---

This is caused by bug 1647443 but I'm not sure why it doesn't work for us.

Comment 1

[Intermittent Failures Robot]

26 failures in 884 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 22
• try-comm-central: 4

Platform breakdown:

• linux64: 5
• linux64-shippable: 2
• windows7-32-shippable: 3
• windows10-64: 6
• windows10-64-shippable: 3
• windows7-32: 4
• macosx1014-64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1657060&startday=2020-08-04&endday=2020-08-04&tree=all

Comment 2

[Geoff Lankow (:darktrojan)]

Dave, can you offer any insight as to why this test would fail on Thunderbird, or if we should even be running it?

Comment 3

[Dave Townsend [:mossop]]

I think you should be running it. It looks like for some reason the test is going on to stage the update rather than stopping after downloading and so it sends out the wrong observer notification. It looks like I may have mistakenly thought that staging is disabled by default in xpcshell tests but I see some of the tests explicitly disabling it. That might be the fix. But then I'm not sure why Firefox is behaving differently here.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1657060 - Disable app update staging in AUS tests. r?Mossop

Comment 5

[Geoff Lankow (:darktrojan)]

You're right, and that's set to true in the default preferences, which for some reason get read during Thunderbird XPCShell tests but not in Firefox ones.

Comment 6

[Intermittent Failures Robot]

20 failures in 948 pushes (0.021 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 20

Platform breakdown:

• macosx1014-64: 3
• linux64: 3
• windows10-64: 4
• windows7-32: 4
• windows10-64-shippable: 2
• windows7-32-shippable: 2
• linux64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1657060&startday=2020-08-05&endday=2020-08-05&tree=all

Comment 7

[Magnus Melin [:mkmelin]]

Why? That's good old bug 1168178... so the app.update.staging.enabled true pref in firefox.js is not used.

Comment 8

[Dave Townsend [:mossop]]

(In reply to Magnus Melin [:mkmelin] from comment #7)

Why? That's good old bug 1168178... so the app.update.staging.enabled true pref in firefox.js is not used.

Sure, that's what I expected. What I don't understand is why are the Thunderbird prefs being used in this case?

Comment 9

[Magnus Melin [:mkmelin]]

Because Thunderbird does run xpcshell tests with normal app profile, so the app.update.staging.enabled true in all-thunderbird.js gets picked up.
We'd miss a lot of needed adjustments if we didn't use that, but it's of course unfortunate - for us, and I think in general too - that Firefox doesn't as well.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9009816330a
Disable app update staging in AUS tests. r=mossop

Comment 11

[Intermittent Failures Robot]

23 failures in 958 pushes (0.024 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 23

Platform breakdown:

• linux64: 4
• windows7-32: 4
• linux64-shippable: 1
• windows10-64: 4
• macosx1014-64: 4
• macosx1014-64-shippable: 2
• windows7-32-shippable: 2
• windows10-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1657060&startday=2020-08-06&endday=2020-08-06&tree=all

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e9009816330a

Comment 13

[Intermittent Failures Robot]

69 failures in 4618 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #14 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 65
• try-comm-central: 4

Platform breakdown:

• linux64: 12
• linux64-shippable: 5
• windows7-32-shippable: 7
• windows10-64: 14
• windows10-64-shippable: 7
• windows7-32: 12
• macosx1014-64: 10
• macosx1014-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1657060&startday=2020-08-03&endday=2020-08-09&tree=all