1657068 - use emojis for incoming smiley upgrades

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, task)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1638874 +++

In bug 1638874 we started using emojis for manual inserts if smileys. We should also start doing that for the incoming smileys that we upgrade to an "html" version, and drop the old way of doing this.

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1657068_remove-old-emoji-use-0.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9169477 [details] [diff] [review]
Bug-1657068_remove-old-emoji-use-0.patch

Review of attachment 9169477 [details] [diff] [review]:
-----------------------------------------------------------------

Yes but you first need a patch to do the upgrade
https://searchfox.org/mozilla-central/source/netwerk/streamconv/converters/mozTXTToHTMLConv.cpp#727

Comment 3

[Khushil Mistry [:khushil324]]

Do we want to just remove it or replace ":-)" etc strings with related smiley unicode?

Comment 4

[Magnus Melin [:mkmelin]]

I think we want to replace with smiley unicodes.

Comment 5

[Khushil Mistry [:khushil324]]

Sure, will update the patch.

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: Bug 1657068 - Use emojis for incoming smiley upgrades

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: bug1657068_emoticon.patch

Looks like it works if we use the char directly. You can build on this wip patch.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9169477 [details] [diff] [review]
Bug-1657068_remove-old-emoji-use-0.patch

Review of attachment 9169477 [details] [diff] [review]:
-----------------------------------------------------------------

Reflag later when the m-c piece is done. 
IIRC there are also c-c tests that may need adjustment

Comment 9

[Khushil Mistry [:khushil324]]

I didn't find any c-c tests for smiley usage.

Comment 10

[Magnus Melin [:mkmelin]]

None directly AFAIK, but I think there are tests that need adjustment to pass.

Comment 11

[Khushil Mistry [:khushil324]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=541715e04990bb8f96abedd1ee26adf749090292

I have sent it for a try run and it's not showing any failure.

Comment 12

[Magnus Melin [:mkmelin]]

You need to modify gecko_rev.yml and set the GECKO_HEAD_REF revision to a firefox try revision where the m-c patch was applied (and GECKO_HEAD_REPOSITORY to https://hg.mozilla.org/try). Otherwise you wouldn't see what problems it would cause.

Comment 13

[Khushil Mistry [:khushil324]]

Revised try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=bebb23d1bed47f270761dddc6b88a6ee5bd88bb5

Comment 14

[Magnus Melin [:mkmelin]]

Attachment: Bug 1657068 - Use emojis for text to HTML smiley upgrades. r=valentin

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c858714b2476
Use emojis for text to HTML smiley upgrades. r=valentin,necko-reviewers

Comment 16

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c858714b2476

Comment 17

[Magnus Melin [:mkmelin]]

Comment on attachment 9169477 [details] [diff] [review]
Bug-1657068_remove-old-emoji-use-0.patch

Review of attachment 9169477 [details] [diff] [review]:
-----------------------------------------------------------------

Needed some unbitrotting, but seems correct.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9960fcdcb354
Remove old emoji usage. r=mkmelin