1657101 - [meta] Enable (all) server side resources by default for tab toolboxes

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

For now, all server side resources have been landed preffed off behind devtools.testing.enableServerWatcherSupport.
Only resource watcher tests are covering this new codepath by manually toggling this preference. So that the test coverage of this is pretty limited and users are still using the old codepath.

We should try to enable all currently implemented server resources unconditionally.
I was delaying this mostly because of bug 1644191 and bug 1644192. Network event and storage resources may have to introduce changes in Watcher actor RDP interfaces.
So I wanted to avoid having to deal with backward compatiblity in the ResourceWatcher code.

The research work on storage and network is still ongoing, but so far, there was no requirement to introduce a change in existing Watcher Actor RDP specification. Only addition, like onResourceUpdated.
Similarly, the work on worker and content process (bug 1633712 and bug 1620248) have not uncovered changes either.

So, we may be enable to enable all resources, while not removing the preference as it will probably be useful for network event, where we would land server side support incrementally.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c).

Comment 2

[Alexandre Poirot [:ochameau]]

I actually already logged a bug for enabing all console resources, bug 1642295. It might be worth doing it seperately from the document-events resource.

Comment 3

[Neha Kochar [:neha]]

It depends on other work that's in Fission M7 so moving this to M7 too.

Comment 4

[Alexandre Poirot [:ochameau]]

Now that NETWORK_EVENT have been enabled (bug 1644191), the only work left is bug 1644192.
Note that this bug is about enabling all resources for tab toolboxes.

Bug 1687459 will followup in order to enable all resources for all types of toolboxes.

Comment 5

[Chris Peterson [:cpeterson]]

DevTools meta bugs don't need to block Fission MVP. However, we will continue to monitor these meta bugs for any new bugs blocking them as potential blockers for Fission MVP.

Comment 6

[Alexandre Poirot [:ochameau]]

This is completed.

All the resources have been implemented and enabled for regular tab toolboxes:
https://searchfox.org/mozilla-central/source/devtools/server/actors/watcher/session-context.js#201-220
We now only miss enabling them for some other toolboxes, mostly the browser toolbox (bug 1687459).