1663523 - Implement Network Event Stacktrace listening via the ResourceWatcher API on the actor side

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Hubert Boma Manilla (:bomsy)]

Lets implement the NETWORK_EVENT_STACKTRACE resource on the actor side.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1663523 - [devtools] Add the network event stacktrace watcher r=ochameau

Comment 2

[Neha Kochar [:neha]]

Bulk move of all m2-mvp devtools bugs to Fission M7.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de71a00c6f68
[devtools] Add the network event stacktrace watcher r=ochameau,devtools-backward-compat-reviewers

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset de71a00c6f68 (bug 1663523) for devtools/shared/ failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=K3RejMBWQGqTPxyXLA87Dw.0&fromchange=de71a00c6f689bde4c5d8cbe331dd6f62fd19f76&searchStr=xpc&tochange=cb4114308a0ebb785c98cb76cb412400bd75434c

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=de71a00c6f689bde4c5d8cbe331dd6f62fd19f76&searchStr=devtools&tochange=cb4114308a0ebb785c98cb76cb412400bd75434c&selectedTaskRun=J1aR80J_SNyfAVxpQ1qAhg.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/cb4114308a0ebb785c98cb76cb412400bd75434c

Failure logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318965578&repo=autoland&lineNumber=2431

[task 2020-10-18T17:44:39.425Z] 17:44:39     INFO -  TEST-START | devtools/shared/protocol/tests/xpcshell/test_protocol_index.js
[task 2020-10-18T17:44:39.784Z] 17:44:39  WARNING -  TEST-UNEXPECTED-FAIL | devtools/shared/protocol/tests/xpcshell/test_protocol_index.js | xpcshell return code: 0
[task 2020-10-18T17:44:39.784Z] 17:44:39     INFO -  TEST-INFO took 357ms
[task 2020-10-18T17:44:39.785Z] 17:44:39     INFO -  >>>>>>>
[task 2020-10-18T17:44:39.786Z] 17:44:39     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-10-18T17:44:39.786Z] 17:44:39  WARNING -  TEST-UNEXPECTED-FAIL | devtools/shared/protocol/tests/xpcshell/test_protocol_index.js | test_index_is_alphabetically_sorted - [test_index_is_alphabetically_sorted : 22] Spec definition for "devtools/shared/specs/stacktraces" should be before "devtools/shared/specs/worker/service-worker-registration" - false == true
[task 2020-10-18T17:44:39.786Z] 17:44:39     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/devtools/shared/protocol/tests/xpcshell/test_protocol_index.js:test_index_is_alphabetically_sorted:22
[task 2020-10-18T17:44:39.786Z] 17:44:39     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/devtools/shared/protocol/tests/xpcshell/test_protocol_index.js:run_test:10
[task 2020-10-18T17:44:39.786Z] 17:44:39     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:571
[task 2020-10-18T17:44:39.786Z] 17:44:39     INFO -  -e:null:1
[task 2020-10-18T17:44:39.786Z] 17:44:39     INFO -  exiting test
[task 2020-10-18T17:44:39.787Z] 17:44:39     INFO -  <<<<<<<
[task 2020-10-18T17:44:39.787Z] 17:44:39     INFO -  INFO | Result summary:
[task 2020-10-18T17:44:39.787Z] 17:44:39     INFO -  INFO | Passed: 116
[task 2020-10-18T17:44:39.790Z] 17:44:39  WARNING -  INFO | Failed: 1
[task 2020-10-18T17:44:39.790Z] 17:44:39  WARNING -  One or more unittests failed.
[task 2020-10-18T17:44:39.791Z] 17:44:39     INFO -  INFO | Todo: 0
[task 2020-10-18T17:44:39.791Z] 17:44:39     INFO -  INFO | Retried: 13
[task 2020-10-18T17:44:39.792Z] 17:44:39     INFO -  SUITE-END | took 283s
[task 2020-10-18T17:44:39.792Z] 17:44:39     INFO -  Node moz-http2 server shutting down ...
[task 2020-10-18T17:44:39.815Z] 17:44:39    ERROR - Return code: 1
[task 2020-10-18T17:44:39.816Z] 17:44:39     INFO - TinderboxPrint: xpcshell-xpcshell<br/>116/<em class="testfail">1</em>/0
[task 2020-10-18T17:44:39.816Z] 17:44:39  WARNING - # TBPL FAILURE #
[task 2020-10-18T17:44:39.816Z] 17:44:39  WARNING - setting return code to 2
[task 2020-10-18T17:44:39.816Z] 17:44:39  WARNING - The xpcshell suite: xpcshell ran with return status: FAILURE

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318965620&repo=autoland&lineNumber=7742

[task 2020-10-18T17:53:58.565Z] 17:53:58     INFO - TEST-START | devtools/shared/resources/tests/browser_resources_network_event_stacktraces.js
[task 2020-10-18T17:53:58.803Z] 17:53:58     INFO - TEST-INFO | started process screentopng
[task 2020-10-18T17:53:59.477Z] 17:53:59     INFO - TEST-INFO | screentopng: exit 0
[task 2020-10-18T17:53:59.478Z] 17:53:59     INFO - Buffered messages logged at 17:53:58
[task 2020-10-18T17:53:59.478Z] 17:53:59     INFO - Entering test bound 
[task 2020-10-18T17:53:59.479Z] 17:53:59     INFO - Test network stacktraces events legacy listener
[task 2020-10-18T17:53:59.479Z] 17:53:59     INFO - Adding a new tab with URL: https://example.com/browser/devtools/shared/resources/tests/network_document.html
[task 2020-10-18T17:53:59.479Z] 17:53:59     INFO - Tab added and finished loading
[task 2020-10-18T17:53:59.480Z] 17:53:59     INFO - TEST-PASS | devtools/shared/resources/tests/browser_resources_network_event_stacktraces.js | The network event does not exist - 
[task 2020-10-18T17:53:59.480Z] 17:53:59     INFO - Buffered messages finished
[task 2020-10-18T17:53:59.481Z] 17:53:59     INFO - TEST-UNEXPECTED-FAIL | devtools/shared/resources/tests/browser_resources_network_event_stacktraces.js | The stacktrace is available - Got undefined, expected true
[task 2020-10-18T17:53:59.481Z] 17:53:59     INFO - Stack trace:
[task 2020-10-18T17:53:59.482Z] 17:53:59     INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-10-18T17:53:59.483Z] 17:53:59     INFO - chrome://mochitests/content/browser/devtools/shared/resources/tests/browser_resources_network_event_stacktraces.js:onResourceAvailable:61
[task 2020-10-18T17:53:59.483Z] 17:53:59     INFO - resource://devtools/shared/resources/resource-watcher.js:_notifyWatchers:557
[task 2020-10-18T17:53:59.484Z] 17:53:59     INFO - resource://devtools/shared/throttle.js:throttle/<:45
[task 2020-10-18T17:53:59.484Z] 17:53:59     INFO - resource://devtools/shared/resources/resource-watcher.js:_onResourceAvailable:370
[task 2020-10-18T17:53:59.485Z] 17:53:59     INFO - resource://devtools/shared/resources/legacy-listeners/network-event-stacktraces.js:onNetworkEventStackTrace:19
[task 2020-10-18T17:53:59.486Z] 17:53:59     INFO - resource://devtools/shared/event-emitter.js:_emit:226
[task 2020-10-18T17:53:59.487Z] 17:53:59     INFO - resource://devtools/shared/event-emitter.js:emit:172
[task 2020-10-18T17:53:59.487Z] 17:53:59     INFO - resource://devtools/shared/event-emitter.js:emit:324
[task 2020-10-18T17:53:59.488Z] 17:53:59     INFO - resource://devtools/client/fronts/webconsole.js:beforeServerNetworkEvent:67
[task 2020-10-18T17:53:59.488Z] 17:53:59     INFO - resource://devtools/shared/protocol/Front.js:onPacket:313
[task 2020-10-18T17:53:59.488Z] 17:53:59     INFO - resource://devtools/client/devtools-client.js:onPacket:492
[task 2020-10-18T17:53:59.489Z] 17:53:59     INFO - resource://devtools/shared/transport/local-transport.js:send/<:68
[task 2020-10-18T17:53:59.489Z] 17:53:59     INFO - resource://devtools/shared/ThreadSafeDevToolsUtils.js:exports.makeInfallible/<:103
[task 2020-10-18T17:53:59.490Z] 17:53:59     INFO - DevToolsUtils.executeSoon*resource://devtools/shared/DevToolsUtils.js:exports.executeSoon:54
[task 2020-10-18T17:53:59.490Z] 17:53:59     INFO - resource://devtools/shared/transport/local-transport.js:send:56
[task 2020-10-18T17:53:59.491Z] 17:53:59     INFO - resource://devtools/server/devtools-server-connection.js:send:99
[task 2020-10-18T17:53:59.491Z] 17:53:59     INFO - resource://devtools/server/devtools-server-connection.js:sendActorEvent:328
[task 2020-10-18T17:53:59.491Z] 17:53:59     INFO - resource://devtools/server/actors/network-monitor/network-monitor.js:onNetworkEvent:283
[task 2020-10-18T17:53:59.492Z] 17:53:59     INFO - resource://devtools/server/actors/network-monitor/network-observer.js:_createNetworkEvent:909
[task 2020-10-18T17:53:59.492Z] 17:53:59     INFO - resource://devtools/server/actors/network-monitor/network-observer.js:_onRequestHeader:938
[task 2020-10-18T17:53:59.493Z] 17:53:59     INFO - resource://devtools/server/actors/network-monitor/network-observer.js:NetworkObserver.prototype.observeActivity<:708
[task 2020-10-18T17:53:59.493Z] 17:53:59     INFO - resource://devtools/shared/ThreadSafeDevToolsUtils.js:exports.makeInfallible/<:103
[task 2020-10-18T17:53:59.494Z] 17:53:59     INFO - TEST-PASS | devtools/shared/resources/tests/browser_resources_network_event_stacktraces.js | The last frame of the stacktrace is available - 
[task 2020-10-18T17:53:59.494Z] 17:53:59     INFO - Leaving test bound 
[task 2020-10-18T17:53:59.495Z] 17:53:59     INFO - TEST-PASS | devtools/shared/resources/tests/browser_resources_network_event_stacktraces.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2020-10-18T17:53:59.495Z] 17:53:59     INFO - GECKO(3599) | MEMORY STAT | vsize 2843MB | residentFast 342MB | heapAllocated 115MB
[task 2020-10-18T17:53:59.496Z] 17:53:59     INFO - TEST-OK | devtools/shared/resources/tests/browser_resources_network_event_stacktraces.js | took 303ms

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

The following seem to start perma failing with the backed out changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318965929&repo=autoland&lineNumber=11984

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76adb5d85f07
[devtools] Add the network event stacktrace watcher r=ochameau,devtools-backward-compat-reviewers

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/76adb5d85f07