1657382 - The `Automatic` theme from the 3rd slide of the onboarding is not highlighted when the theme section is focused via keyboard navigation

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: 2nd theme is selected with keyboard navigation.gif

[Affected versions]:

• Firefox Beta 80.0b3, Build ID 20200803045446
• Firefox Nightly 81.0a1, Build ID 20200803094100

[Affected Platforms]:

• Windows 10
• macOS 10.15
• Linux MX 4.19

[Steps to reproduce]:

1. Open Firefox Beta with a clean new profile.
2. Navigate to the 3rd slide of the onboarding.
3. Press the Tab key once and observe the behavior.

[Expected results]:

• The first theme, Automatic, is highlighted.

[Actual results]:

• The whole theme section is highlighted.

[Notes]:

• When pressing the Left or Down arrow keys the focus is changed to the 2nd theme, when the expectation would be to start from the 1st one.
• Attached a screen recording of the issue.

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1657382 - Fix highlight for Automatic theme on theme screen of about:welcome

Comment 2

[Emily McMinn :emcminn]

We're expecting this to be fixed by bug 1654122; if it isn't, we can revisit this patch.

Comment 3

[Emily McMinn :emcminn]

Attachment: Theme keyboard selection.mov

Looks like this is essentially fixed by the selected state, since Automatic is the default, and in the case of another theme being selected and the 'back' button being pressed, keyboard focus starts on the selected theme.

Comment 4

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Nightly build 83.0a1 (BuildID 20200927215113) using Windows 10, macOS 10.15, and Linux MX 4.19.