1657526 - Copy from URLbar adds extra http:// with decodeURLsOnCopy

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Tyson F Nuss]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Using Firefox 79.0 on Windows 10:

1. In about:config set browser.urlbar.decodeURLsOnCopy=true;
2. Browse to an https: site that does not include a www hostname -- e.g.:

• https://robbinsautotop.com
• https://shopdemo.e-junkie.com

3. Select the page URL in the URLbar and Copy to clipboard;
4. Paste the clipboard anywhere convenient.

Actual results:

Pasted URL is prepended with an extra http:// -- e.g.:

• http://https://robbinsautotop.com
• http://https://shopdemo.e-junkie.com

Expected results:

URL should be copied to clipboard as shown in URLbar -- e.g.:

• https://robbinsautotop.com
• https://shopdemo.e-junkie.com

Comment 1

[Drew Willcoxon :adw]

Thanks for reporting this. I can reproduce it on 79 and Nightly. I verified that this is a regression from bug 1647200, but that bug is also about this same thing.

Comment 2

[Marco Bonardo [:mak]]

And this is why preferences are expensive :)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1647200

Comment 4

[Julien Cristau [:jcristau]]

We're in the last week of beta 80 and this isn't new so marking as fix-optional.

Comment 6

[Alexander Gavrilov [:dartraiden]]

www-domains are affected too
http://https://www.reddit.com

Comment 7

[Marco Bonardo [:mak]]

Attachment: Bug 1657526 - Copy from URLbar adds extra http:// with decodeURLsOnCopy. r=dao

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24a573cb3cac
Copy from URLbar adds extra http:// with decodeURLsOnCopy. r=dao

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/24a573cb3cac

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 9172334 [details]
Bug 1657526 - Copy from URLbar adds extra http:// with decodeURLsOnCopy. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Copying a url when the decodeURLsOnCopy pref is set adds an unwanted double protocol
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps are in comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is very simple and has a test
• String changes made/needed:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5cb9ad97c27f

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172334 [details]
Bug 1657526 - Copy from URLbar adds extra http:// with decodeURLsOnCopy. r=dao

Approved for 81.0b4.

Comment 13

[Alexandra Martin]

Confirming issue as verified fixed on latest Nightly 82.0a1 (20200830213209) and Beta 81.0b4 (20200829200810) on Windows 10 x64bit and MacOS 10.14.6.