1657590 - [deathwishcoffee.com] CC autofill does not work anymore

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Recording of the issue

Affected version:
Fx80 and FX81 - if CC specific prefs are enabled

Tested on:
Windows 10

Steps to reproduce:

1. Have 1 CC profile saved
2. Reach the payment form for https://www.deathwishcoffee.com
3. Click on any of the field with <autocomplete> attribute and select the suggested CC info from the autofill dropdown

Expected Result:
All the expected fields should be autofilled

Actual Result:
Only the active field is autofilled, the rest remain blank.
There is also no yellow highlight displayed for the autofilled field.

Regression-range:
This is also a regression introduced by Bug 1604807
2020-08-06T12:04:24.671000: DEBUG : Found commit message:
Bug 1604807: Set text field values through formFillController to avoid races r=zbraniecki

Differential Revision: https://phabricator.services.mozilla.com/D82637

Notes:
Looking at the telemetry events, it registered like the fields were detected and autofilled but they were not:
6874094 creditcard detected cc_form {87c07651-6c74-4426-80e3-8a8e9bac0eda} {"cc_name_found": "true", "cc_number_found": "true", "cc_exp_found": "true"}

"5471328 creditcard filled cc_form {2e443845-3c62-41bf-865a-33e2137748cf} {"cc_name": "filled", "cc_number": "filled", "cc_exp": "filled"} "

Comment 1

[Timea Cernea [:tbabos][inactive]]

Please also check this one out when you can. Thanks!

Comment 2

[Adam Roach [:abr]]

Thanks. This looks like it might

Comment 3

[Timea Cernea [:tbabos][inactive]]

Suggesting S2 severity since the feature is not functional at all on this site and it is also a regression.

Comment 4

[Adam Roach [:abr]]

Fixed by Bug 1658086

Comment 5

[Alin Ilea, Desktop QA]

Attachment: 2020-08-14_11h18_27.mp4

In my attempt to verify the fix I noticed some issues. Indeed, all the expected fields are autofilled now, but the yellow highlight is missing, the expiration date is incorrect autofilled (YYYY-MM instead of MM/YY) and the "Clear autofill form" option is not displayed in the "Name on Card" and "Expiration Date" CC drop-down, it is displayed just in the Card number drop-down.

Comment 6

[Adam Roach [:abr]]

(In reply to Alin Ilea from comment #5)

In my attempt to verify the fix I noticed some issues. Indeed, all the expected fields are autofilled now, but the yellow highlight is missing, the expiration date is incorrect autofilled (YYYY-MM instead of MM/YY) and the "Clear autofill form" option is not displayed in the "Name on Card" and "Expiration Date" CC drop-down, it is displayed just in the Card number drop-down.

Hi! These behaviors existed prior to 1604807, and should be filed as a separate bug. Thanks!

Comment 7

[Alin Ilea, Desktop QA]

Based on the fact that the initial issue from this bug is not reproducible anymore in latest Nightly 80.0a1 (build id: 20200819212829), all the expected fields are autofilled, I will mark this as verified and will log a new bug the incorrect behavior from comment 5.
Thanks.