1657676 - Update keywordoffer results for search mode

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Harry Twyford]

When "@" is typed, we show all the user's token alias engines. The results read @enginename — Search with Enginename. Since @ results are mostly being superseded by update2's search mode, we should discuss changing the look of these results with UX.

Maybe we could just show normal keyword offer engine results. That is, all the results for the "@" query just read Search with Enginename. As the user moves through the results, we could add/change the search mode indicator instead of autofilling @enginename. This would be similar to how we're planning to handle tab-to-complete results.

Comment 1

[Harry Twyford]

I'll focus this bug on just cycling through search modes as the user moves through keywordoffer results. We will enter the keywordoffer's search mode without executing a new query. As the user continues moving through results and leaves the keywordoffer, we will restore text to the Urlbar from UrlbarInput._getValueFromResult.

Comment 2

[Harry Twyford]

Attachment: cycling.jpg

UX confirms that we should drop the @alias from the result title when the user types @. When the user cycles through the results, we should enter search mode without executing a new query (i.e. show the search mode indicator and do nothing else).

Comment 3

[Harry Twyford]

We should do the same thing for keywordoffer Top Sites, per the drawing.

Comment 4

[Harry Twyford]

Attachment: Bug 1657676 - Add search mode preview.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e3078121a13
Add search mode preview. r=adw

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 6e3078121a13 (bug 1657676) for bc failures at browser_oneOffs_keyModifiers.js.
https://hg.mozilla.org/integration/autoland/rev/16b72b1a53059c7bad95655dfa3177aa13d203d0

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=a66e59b5ced7698ed8a035381d1ed3734d782fb1&selectedTaskRun=EPXdBhQETPCbk_QaIAIzdA.0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315795740&repo=autoland&lineNumber=5759

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b445d02b1367
Add search mode preview. r=adw

Comment 8

[Dorel Luca [:dluca]]

Backed out changeset b445d02b1367 (bug 1657676) for Browser-chrome failures in newtab/test/browser/browser_topsites_section.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315898446&repo=autoland&lineNumber=9481

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=b445d02b136718eca7816a246de054b0449e9f39

Backout:
https://hg.mozilla.org/integration/autoland/rev/286a46e81e2fe08a0d3a6f6d98296c922cec71cb

Comment 9

[Harry Twyford]

New revision: https://treeherder.mozilla.org/#/jobs?repo=try&revision=667e4ca2df111e5b7081456f4022c046b04a239b

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4d5918d6670
Add search mode preview. r=adw

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c4d5918d6670

Comment 12

[Florencia Di Ciocco, NI to vbalducci]

Attachment: F83

Hi,
I just verified this and I noticed that when I type @, bookmarks, tabs and history are not shown on the list as was shown in cycling.jpg.
Was this intended? This happens both in FF83 and 84.

Regards, Flor.

Comment 13

[Harry Twyford]

Thanks for finding this. I'm not 100% sure what UX thinks here so I'll ask them in our next meeting. I'll keep the needinfo as a reminder to come back to this.

Comment 14

[Harry Twyford]

UX still wants Bookmarks, History, and Tabs to appear for searches for "@". Thanks again for reporting this, Flor. I filed bug 1675048.

Comment 15

[Florencia Di Ciocco, NI to vbalducci]

Awesome, thanks to you for asking ux and for filing the new bug :)