1666927 - Unable to tab past keywordoffer results with update2 enabled

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Harry Twyford]

Bug 1657676 changed keywordoffer results to preview search mode when they are selected. That means they show the search mode indicator and clear the Urlbar value. However, this breaks the behaviour changed in bug 1616880, where tab only cycles through results when there's no search string.

We probably just need to update allowTabbingThroughResults to allow tabbing when search mode is active and !!searchMode.isPreview. We should check for isPreview to avoid breaking our a11y tab behaviour when the user is in "full" search mode, blurs the Urlbar with no search string, then refocuses it; in this case, Tab should still move to the next toolbar element.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1657676

Comment 2

[Harry Twyford]

Attachment: Bug 1666927 - Allow tabbing past keywordoffer results with update2 enabled. r?adw!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/680a99a50a1e
Allow tabbing past keywordoffer results with update2 enabled. r=adw

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/680a99a50a1e

Comment 5

[Harry Twyford]

When Tab is pressed, SearchOneOffs nulls its selectedButton. From that call, UrlbarSearchOneOffs calls UrlbarInput.restoreSearchModeState(). Bug 1655486 changed restoreSearchModeState to only restore non-preview search mode. So when Tab is pressed on a result previewing search mode, we actually exit search mode. Then when we get to the UrlbarController Tab handler, allowTabbingThroughResults is false because we are not in search mode, let alone search mode preview.

Comment 6

[Harry Twyford]

Ah, I posted in the wrong bug 😓