1657909 - The blank fields are wrongly recorded as "field_modified" when manually complete and submit a form

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: fields_modified.gif

[Affected versions]:

• Nightly 81.0a1;
• Beta 80.0b5;

[Affected Platforms]:

• All Windows;
• All macOS;
• All Linux;

[Prerequisites]:

• Have a Firefox profile with the following prefs set:
  • Have the "extensions.formautofill.creditCards.available" pref set to "true";
  • Have the "extensions.formautofill.creditCards.enabled " pref set to "true";

[Steps to reproduce]:

1. Open the Firefox browser and navigate to https://luke-chang.github.io/autofill-demo/basic_cc.html
2. Complete only the Card Number field with valid information.
3. Click the "Submit" button.
4. Click the "Save" button from the doorhanger.
5. Navigate to "about:telemetry#events-tab" page.
6. Search for the {"category:creditcard", "method:submitted") event.
7. Observe the "extra" column.

[Expected result]:

• The "field_modified" contain the number of the modified fields: 1 since only the number card was filled.

[Actual result]:

• The "field_modified" has the value "4" even if only one field was completed.

[Notes]:

• We are also not sure if the "field_modified" should or should not count the new manually entered information as a field modified. However, I considered that this is intended since initially, the field is blank and then it is modified by adding new information. Please correct me if I'm wrong.
• Attached a screen recording with the issue.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Actually, it should be fields_not_auto that is populated in a new form scenario.
Fixing this bug is mainly a matter of avoiding papercuts.

This is a minor issue since in all statistics we're going to look for those fields for cases where the credit card is being autofilled (so, use autofill), not for cases where a new form is submitted with a new card.

In such case autofill and autofill_and_modified makes no sense.

My plan is to calculate all elements in a form that have value which is not null as "fields_not_auto" in this scenario.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1657909 - Improve calculation of fields telemetry for Credit Card Autofill. r?abr

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86c7c0bb421e
Improve calculation of fields telemetry for Credit Card Autofill. r=abr

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/86c7c0bb421e

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 9168876 [details]
Bug 1657909 - Improve calculation of fields telemetry for Credit Card Autofill. r?abr

Beta/Release Uplift Approval Request

• User impact if declined: We'll carry over improper calculations in edge scenarios of credit card telemetry.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's only affecting minor telemetry calculations
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9168876 [details]
Bug 1657909 - Improve calculation of fields telemetry for Credit Card Autofill. r?abr

approved for 80.0b7

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/801a6778fde3

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 81.0a1 build (Build ID: 20200809213940) on Windows 10 x64, Mac 10.14.6 and Ubuntu 20.04 x64.

• The submit event correctly counts the {"fields_not_auto": "", "fields_auto": "", "fields_modified": ""} fields.

I will also verify this issue as soon as the next Beta 80 build will be available.

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this bug on the latest Beta 80.0b7 (Build ID: 20200811133449) on Windows 10 x64, Mac 10.14.6 and Ubuntu 20.04 x64.

• The submit event correctly counts the {"fields_not_auto": "", "fields_auto": "", "fields_modified": ""} fields.