1657920 - Ensure that DONTBUILD gets ignored on backstop pushes

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect, P2)

Description

[Andrew Halberstadt [:ahal]]

If someone pushes to autoland with DONTBUILD in the commit message, builds and tests won't be scheduled. Presumably this is because the change is trivial.

However if the push would have been a backstop push (a push would otherwise have run everything to make sure we didn't miss any regressions), it means the backstop is wasted and we need to wait another 10 pushes for the next one. This makes it harder for sheriffs as there are fewer merge candidates and regression ranges are bigger.

Comment 1

[Andrew Halberstadt [:ahal]]

With https://bugzilla.mozilla.org/show_bug.cgi?id=1660506 being solved, there's now an index we can use to find the latest backstop push. Rather than ignoring DONTBUILD, this means we could bump the backstop back a push. We could decide whether or not to keep these going based off of push id, or whether we can allow them to digress (if we do the latter, we'd need to also fix expanded pushes to do the same).

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1657920 - always run all tasks for backstop pushes. r=ahal

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46ef17236856
always run all tasks for backstop pushes. r=ahal,taskgraph-reviewers DONTBUILD

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/46ef17236856

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out from Beta for causing bug 1885839.
https://hg.mozilla.org/releases/mozilla-beta/rev/a34469cef548e63399bffdfa31c2225c11314237