1885839 - DONTBUILD is ignored on release branches

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Julien Cristau [:jcristau]]

Bug 1657920 made it so DONTBUILD is ignored on backstop pushes, but is_backstop always returns true outside try and autoland (https://searchfox.org/mozilla-central/rev/529f04f4cd2ae68a0f729ba91cf8985edb23e9d3/taskcluster/gecko_taskgraph/util/backstop.py#45-46)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1657920

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Andrew Halberstadt [:ahal]]

We can likely solve both this and the original problem in bug 1657920 by adjusting our backstop detection logic.

Namely:

1. Backout bug 1657920
2. Make is_backstop return False when DONTBUILD is present.
3. Instead of running a backstop on pushlog_id % 20 == 0, compute it based on whether the difference in pushlog_id from the last backstop in the index and this one is greater than 20.

This way, a DONTBUILD push will never be considered a backstop. If this would have been the 20th push since the last backstop, it won't be be considered a backstop, won't populate the index and the next non-DONTBUILD push will be the backstop instead.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Fixed by backout for Beta125.
https://hg.mozilla.org/releases/mozilla-beta/rev/a34469cef548e63399bffdfa31c2225c11314237

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1885839 - Backed out changeset 46ef17236856 for regressing DONTBUILD on release branches, r?jcristau!

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1885839 - Compute backstop interval based on pushlog_id of the last backstop, r?jcristau!

This computes backstop interval based on the pushlog_id of the last backstop,
rather than naively making every 20th pushid a backstop. This solves the
problem of when the 20th pushid ends up being a DONTBUILD push. Previously,
this would have meant we miss an entire backstop and need to wait another 20
pushes. Now, it means the next non-DONTBUILD push will become the backstop.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f28beaf40f7e
Backed out changeset 46ef17236856 for regressing DONTBUILD on release branches, r=jcristau,taskgraph-reviewers
https://hg.mozilla.org/integration/autoland/rev/a182e0c9f40c
Compute backstop interval based on pushlog_id of the last backstop, r=jcristau,taskgraph-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22703e3dc98b
Fix Gecko decission failures. CLOSED TREE

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1885839 - Update test_util_backstop.py to use string pushlog_ids, r?#taskgraph-reviewers!

This more accurately represents the actual parameter and would have caught a
regression had it existed before I landed.

Comment 10

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/f28beaf40f7e
https://hg.mozilla.org/mozilla-central/rev/a182e0c9f40c
https://hg.mozilla.org/mozilla-central/rev/22703e3dc98b

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d538b1c04e8e
Update test_util_backstop.py to use string pushlog_ids, r=taskgraph-reviewers,jcristau

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d538b1c04e8e