1657982 - Make test_bug593174.html to pass on Fission

Status: RESOLVED DUPLICATE of bug 1668357

(Core :: DOM: Navigation, task, P3)

Comment 1

[Chris Peterson [:cpeterson]]

Session history blocks our Nightly experiment so tracking session history test failures for Fission Nightly milestone M6b.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

Passes locally with ./mach mochitest --setpref="fission.sessionHistoryInParent=true" --enable-xorigin-tests --enable-fission dom/tests/mochitest/bugs/test_bug593174.html. Fails without fission.sessionHistoryInParent=true. Hence, it should be tested on Try, once bug 1656208 is fixed.

Comment 3

[Jens Stutte [:jstutte]]

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

Comment 4

[Neha Kochar [:neha]]

(In reply to Jens Stutte [:jstutte] (REO for FF 81) from comment #3)

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

No, I'll move the meta to M6c to better reflect many of the dependency bugs. Each test should be reviewed in light of the failure cause:

• If it's a broken feature/functionality, fix in M6b (unless it can be argued that it isn't widely used and is acceptable to be broken for some time during the nightly experiment)
• If it's a broken test i.e. test itself needs changes to fix incorrect assumptions that were accidentally met before but are no longer true with fission, or timing/delay changes, then fix in M6c.

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

I'm waiting for bug 1656208 to be fixed, hence not actively working on this, hence setting Status to "NEW", but keeping it assigned to me.

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1657982: enable "test_bug593174.html" for xorigin iframes with Fission. r=smaug

Requries session history in parent (bug 1656208).

Comment 7

[Neha Kochar [:neha]]

Mirko has already verified that the test passes with session history pref so enabling the test itself is a trivial task that can be moved to M6c. Nothing to fix here.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mbrodesser, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Neha Kochar [:neha]]

Mirko, sessionHistoryInParent is now enabled with Fission (in bug 1668357) so you can re-enable this (and the other tests that were waiting for SHIP) for Fission now. Thanks!

Comment 10

[Mirko Brodesser (:mbrodesser-Igalia)]

:neha: thanks for letting me know. Then bug 1656208 should be closed, or?

Comment 11

[Mirko Brodesser (:mbrodesser-Igalia)]

Already enabled in bug 1668357.